On 06/14/12 20:04, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/7176881-v1

Bugs:
7176881 _RepoStore doesn't pass on changes to read_only
7176886 using cached Repositories breaks multi-publisher publishing

This fix helps Tim land his granular proxy work. As part of that work,
he made the change on line 2788 of transport.py which had unfortunate
fallout. These changes fix the issues that line change causes.

src/modules/client/transport/transport.py:
  line 2788: Can you add a comment like this:
    # Trailing '/' must be stripped to match behaviour of
    # get_repostats() call in publish_cache_repository().

src/modules/client/transport/repo.py:
  line 1646-1647: nit: newline before and after this to match
    the style of all the other publish_*() functions.

    Although it isn't strictly necessary, the same fix should
    probably be applied to publish_add_file().

Thanks for sussing this out; my bad for missing the cache_store thing.

You were also right to not like the solution of creating a publisher directory and catalog if the prefix is set.

-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to