On Mon, Jun 18, 2012 at 10:42:51AM -0700, Bart Smaalders wrote: > On 06/18/12 00:08, Edward Pilatowicz wrote: > >hey all, > > > >i have a small solver bugfix i'd like reviewed: > > > >https://cr.opensolaris.org/action/browse/pkg/edp/pkg.7177714/webrev/ > >7177714 zone install can create out of sync zones when using the dev > >repository > > That's one way of fixing this, but it's a little gross > since it hardcodes the problem cases and needs attention if > another package ever gets a new parent dependency. > > You could also iterate over the parent packages doing > a comb_auto_fmris on the pkgs w/ parent self dependencies... > sort of the reverse of of __trim_nonmatching_parents. > This would not require a hardcoded list, and would automatically > take care of any packages getting new parent dependencies in the > future. >
i realize that hard coding package names is kinda gross, but this is a special case to deal with previously published bad packages. once the old packages are expunged from the dev repo we can remove this hack. (that would be another way to fix this problem.) also, given that the solver is a performance critical path, i really didn't want to do any iterating over all packages for another operations. finally, it's perfectly valid for the parent dependency to be added/removed from different versions of packages. (if say all the drivers are removed from one package and moved to another, that package may no longer have a parent dependency.) if this hack is considered too gross then i'd just say we can close it as will-not-fix and then hope for the best for internal users (until older builds get expunged from the dev repo). ed _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
