On 06/16/12 18:08, Edward Pilatowicz wrote:
hey all,
i've got an updated webrev for these changes:
https://cr.opensolaris.org/action/browse/pkg/edp/pkg.pli.cr3/webrev
this webrev addresses code review feedback from danek and shawn.
i also have a diffs webrev againt the the cr1 and cr2 webrevs [1]:
https://cr.opensolaris.org/action/browse/pkg/edp/pkg.pli.cr3/webrev.cr1.diff
https://cr.opensolaris.org/action/browse/pkg/edp/pkg.pli.cr3/webrev.cr2.diff
note that the diffs against the last webrev contain some noise because
of the gate resync. sorry.
if you're internal and you want to try these bits out then upgrade to
s11u1_17 or later and do:
I'm confused about the man page changes; is that because Alta is
handling those?
src/modules/client/api.py:
line 1289-1294, 1444-1450, 1496-1502, 1687-1692: Looks like these can
be rewrapped now; some things will fit on a single line.
line 1983: 'the' equivalent
src/modules/client/pkgremote.py:
line 202: extra newline
line 366: No closing ')' for this comment?
src/tests/api/t_misc.py:
update copyright
src/tests/cli/t_pkg_temp_sources.py:
update copyright
line 901: end of class; so add another newline
I tried to remove everything Danek already commented on from the list above.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
