On 06/18/12 15:28, Shawn Walker wrote:
On 06/18/12 15:05, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/7155053-v1
Bug:
7155053 pkgdepend resolve throws traceback when -e file does not exist
src/pkgdep.py:
line 293: Just curious; why the picking apart of e.args instead of
just relying on stringification of 'e' ?
The stringification of e includes "[Errno 2]" which doesn't really seem
to me to belong in an intentionally user visible error message. I used
the same formatting that pkgsend used. The better solution may be to
have apiErrors._convert_errors know how to convert ENOENT errors as
well, but I was concerned about the amount of unintended (and hard to
detect) changes that might introduce.
src/tests/cli/t_pkgdep_resolve.py:
line 736: s/tracebackhappens/traceback happens/
Thanks,
Brock
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
