On 06/20/12 11:28 PM, Shawn Walker wrote:
On 06/20/12 04:00, Saurabh Vyas wrote:
Hi All,

Please if you can review the changes for (for the SRU branch)

7133915 pkg update leaves out some needed packages
7152298 pkg verify -v should indicate when preserved files have been
modified or overlaid
7161790 zoneadm installs adds package with only global zone variant
7165703 onu cannot uninstall entire

webrev :
https://cr.opensolaris.org/action/browse/pkg/saurabhv/CR-7133915-rev0/webrev/


src/tests/cli/t_variants.py:
lines 155-172: This looks like a mis-merge; the same function
appears twice. Delete these lines.

The rest of the changes seem fine,

Thanks a lot Shawn for quick response.
I have removed the duplicate test function.
Updated webrev : https://cr.opensolaris.org/action/browse/pkg/saurabhv/CR-7133915-rev1/webrev/

Please let me know if this looks fine.
If anyone do not have any further comment, I will proceed with the RTI process (may be by tomorrow )

Thanks,
Saurabh

-Shawn


--


Saurabh Vyas
Solaris Install Group,
Revenue Product Engineering (RPE), Systems |Bangalore |
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to
developing practices and products that help protect the environment
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to