Brock Pytlik wrote:
> https://cr.opensolaris.org/action/browse/pkg/bpytlik/7140241-v1
pull.py:
- line 619: I don't understand why, on a dry-run, total_processed is
incremented by one for each publisher. Why not by len(good_matches),
which would match, in number if not in implementation, how
total_processed would get incremented on a real run?
t_pkgrecv.py:
- line 687-689: this was a bit confusing to read. Perhaps just have two
variables (foo = "string" in self.errout), and then assert on the or of
those two variables? Or even just put each test on its own line, if
they'll fit (line break after the first paren would help with that).
- line 690: I'd reword the message as "%s not in error".
- line 771: probably should create the archive with .p5p extension, in
case someone goes digging and wonders what that file is.
- line 776: space after comma.
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
