On 06/22/12 15:42, Bart Smaalders wrote:
https://cr.opensolaris.org/action/browse/pkg/barts/release-notes/webrev/
7137406 pkg image-update could display release notes (or pointer to)
This changeset doesn't include man page changes.
[snip]
Without -v, if any release notes apply to the upgrade the user has
performed, he would be reminded to read them and told how to do so.
If any file with a release note that applies has must-display=true as
well, the release notes will be always be displayed whether or not -v is
used. Release notes for previous packaging operations can be read (&
file name retrieved) using pkg history -N. Release notes prepared for
new boot environments are stored in the new BE; they are also written
to a temporary file and a path given so they may be reviewed easily
prior to reboot.
Just to clarify, if one release note has must-display=true set, then all
release notes are displayed?
Other than that, everything seems to be nits to me.
client.py:
1127, 1131, 1133, 1139: nit line wrap
1205,1206: why not release_notes = plan.get_release_notes()? Or
list(plan.get_release_notes())?
api.py:
4761: nit: indent 4 spaces
history.py:
444: does the file opened here ever get closed? do we care?
imageplan.py:
2030: it might be nice to dump a copy of some of what was in the email
above in as a comment/docstring so that it's easier in the future to
know what the code's supposed to do
2087: Just curious, why does the decoding need to be done line by line
instead of note by note?
2101-2104: should this be in a try block, with 2105 in a finally block?
misc.py:
1980: maybe I'm just being dense, but I can't figure out why this change
was needed
pkg5unittest.py:
808: nit: line wrap
Brock
- Bart
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
