On 06/25/12 17:25, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/7177231-v1
Bug:
7177231 displayed license is always for installed copy if license file
is present
src/modules/actions/license.py:
line 193: Don't need open() here since fh is never used.
get_data_digest() can accept either a path or fh, so i'd just pass it
the path as you are now and drop the open() call. You should leave the
exception handler in place though.
general: Not this bug, but I wonder what happens if we can't contact
the publisher repository to retrieve the license payload. Do we
traceback? If so, we should file a bug on that...
src/tests/cli/t_pkg_info.py:
copyright update
Thanks,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
