On 06/25/12 05:32, Abhinandan Ekande wrote:
Folks,
Here is updated webrev :
https://cr.opensolaris.org/action/browse/pkg/ae112802/7166082-rev2/webrev/
Incorporated all the comments except the requirement on system/local/extra
package.
The major change included in this webrev is test case has been modified.
Replaced
test case for "pkg publisher" command with test case for "pkg --help"
command.
With the integration of changeset 2701 output of "pkg publisher" command
changed.
Basically the header for "pkg publisher" command has changed. So we have
selected
"pkg --help" command which is relatively stable. Please let me know
feedback on
the latest webrev.
local.getpreferredencoding() has some pitfalls. As a result, I think
you're better of using the result of locale.getlocale()[1].
See this pages for details:
http://stackoverflow.com/questions/4082645/using-python-2-xs-locale-module-to-format-numbers-and-currency
The pydoc for getpreferredencoding() on docs.python.org also warns that
the result is a "guess" at user preferences. So it seems like
getlocale() is the better answer, especially as we've already called
setlocale() at this point. But it would be nice to know for certain.
src/modules/client/history.py:
lines 107-109: I don't think we should have this here. Only the main
program module should be setting locale information.
src/sign.py:
update copyright
src/util/publish/pkgfmt.py:
update copyright
src/util/publish/pkglint.py:
update copyright
src/util/publish/pkgmogrify.py:
update copyright
-Shawn
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
