Tim Foster wrote:
> http://cr.opensolaris.org/action/browse/pkg/timf/pkglint-grab-bag/webrev
Have you run this over a recent WOS build to see if any of the new tests
are triggering warnings?
pkglint_action.py:
- line 745: either merge into the previous paragraph or put a blank line
between them. Line 747 probably should be separated and indented, too.
pkglint_manifest.py:
- line 513: if you use attrlist(), then you don't need the isinstance()
check on line 518.
- line 550ff: is there no code that could be reused to parse the config
file?
- line 575: delete blank line
- line 644: it's not possible to skip a subtest like this, is it? I
would think that not having a classification is something that we might
require in Solaris, but not something everyone is going to care about
(particularly since it's not especially useful, IMO).
- line 674: ".xml"?
- line 677: I'd just use "not (A or B)" or "not A and not " rather than
use any().
t_pkglint.py:
- line 650: square bracket should be on the next line, below the "c" of
"cmdlines".
pkglintrc:
- Will this change require any consolidations to modify an existing
pkglintrc?
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
