Abhinandan Ekande wrote:
> https://cr.opensolaris.org/action/browse/pkg/ae112802/7140762-rev3/webrev/
repository.py:
- line 1635: I would keep the "elif e.errno not in ( ... )" construction,
which should have the same effect, but be slightly more compact.
t_pkgrepo.py:
- line 1364, 1377: use "publish" instead of "pull"
- line 1372: We only test both because the OS happens to test for the
EINVAL condition before the EEXIST condition. It could go the other
way around, and then we'd only be testing the EEXIST condition. Is
there value in this sort of combo test? It might make sense to test to
make sure that truck@2 is still there, but that's not going on here.
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
