On 08/01/12 19:18, Tim Foster wrote:
Hi Brock,
On 08/ 2/12 01:55 PM, Brock Pytlik wrote:
Webrev
https://cr.opensolaris.org/action/browse/pkg/bpytlik/7140807-v1
Bugs:
7140807 sysrepo should not cache catalog responses
7186990 mod-wsgi .sock file makes archiving sysrepo tests harder than
necessary
This looks fine, though I'm curious about the test case for 7140807.
It looks like the test just checks that it can install any version of
foo and bar, rather than installing the @1.0 versions through the
sysrepo (which would have caused the catalog to get cached before this
fix), then publishing the @1.1 versions upstream of the sysrepo, and
specifically trying to install those exact versions through the
sysrepo: if we were still being served a cached catalog, I'd expect
that to fail.
Does that make sense, or am I missing something?
I'll change them to install [email protected] specifically. You're absolutely
right on the bar packages, but the foo package isn't published in repo
1, so installing foo will fail if the catalog's cached. The short
version is that I know the test failed before my change (for the right
reason) so I know it works, but you're right it could be improved!
Thanks for catching that :)
Brock
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
