On 08/08/12 02:46, Tim Foster wrote:
Hi there,
I've another small code review here that fixes how granular proxies
work with 'pkg set-publisher -p', ensuring that the --proxy argument
gets applied to all origins/mirrors that are auto-configured, not just
the URI passed on the command line.
Along with this change and a corresponding test case, I've added a
test case to make sure that --proxy works properly with multiple -g or
-m arguments (that worked fine before this changeset, we just didn't
have a test for it)
https://cr.opensolaris.org/action/browse/pkg/timf/proxy-set-pub-p/proxy-set-pub-p-webrev/
This LGTM. Might it be worth testing the combination of proxies, -g, and
-p with a publisher that's already configured? My reading of the code
makes me think it'll work, but I think it's probably worth testing.
Thanks,
Brock
Comments would be most welcome.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
