On 08/09/12 13:01, Shawn Walker wrote:
On 08/07/12 17:48, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/7140592-v1
Bug:
7140592 publishing an un-payloadable action with a payload dumps
stacktrace
Seems right.
Although, have you checked actionbench results before and after to see
what sort of impact these changes have?
It should be nearly unnoticeable, but occasionally I've discovered
unexpected performance changes when making seemingly innocuous changes
in the action parsing code.
That's a fair question. The answer is that I couldn't see any difference
(in fact the new code ran faster on action creation 2 out of 3 times).
Thanks for suggestion that test.
Brock
Cheers,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
