On Fri, Aug 10, 2012 at 03:32:20PM -0700, Brock Pytlik wrote: > On 08/10/12 15:18, Shawn Walker wrote: > >On 08/10/12 14:58, Brock Pytlik wrote: > >>7190400 key error traceback from _li_recurse_end_output when installing > >>a ng zone > >> > >>$ hg export 2767 > >># HG changeset patch > >># User Brock Pytlik <[email protected]> > >># Date 1344634982 25200 > >># Node ID 3962a3f5d4c580c9d54842e3ce202b73f85beb79 > >># Parent acc2eb2de1c491a0585dc89301466005bf4eb49d > >>7190400 key error traceback from _li_recurse_end_output when installing > >>a ng zone > >> > >>diff -r acc2eb2de1c4 -r 3962a3f5d4c5 src/modules/client/progress.py > >>--- a/src/modules/client/progress.py Thu Aug 09 15:07:36 2012 -0700 > >>+++ b/src/modules/client/progress.py Fri Aug 10 14:43:02 2012 -0700 > >>@@ -711,6 +711,7 @@ > >>max(len(x) for x in self.phase_names.values()) > >> > >>self.li_phase_names = { > >>+ self.PHASE_PREPLAN: _("Startup"), > >>self.PHASE_PLAN: _("Planning"), > >>self.PHASE_DOWNLOAD: _("Downloading"), > >>self.PHASE_FINALIZE: _("Executing"), > >> > >>I'd appreciate a quick turnaround on the review please as this is > >>actively causing issues. > >>Thanks to Pete for supplying the fix. > >>I tested this by installing a zone on my box (which was failing before > >>the fix). I'll file a bug for better automated testing of linked image > >>progress tracking but I didn't want to hold up this fix for that. > > > >This seems like the right fix for now, but I can't help but wonder > >if PHASE_PREPLAN is a state we weren't intended to be in in > >general. > I agree. I wondered about that as well, but with Dan offline, > expediency won out. >
sorry i didn't reply earlier, i had to leave the office early today. this looks fine to me, but i'm not an expert on all the new progress tracker code... that'd be dan. :) wrt the display plan states, i'm guessing that since AI uses the pkg api directly, it's probably calling api interfaces in a different manner that the pkg client does. (iirc, AI does multiple operations on an image, if so perhaps they're doing them all with the same api object.) ed _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
