On 08/07/12 19:48, Edward Pilatowicz wrote:
webrev:
https://cr.opensolaris.org/action/browse/pkg/edp/pkg.refresh/webrev/
bugs:
7187946 pkg running in a zone always thinks it's modifying a non-active BE
7185502 need to document pkg change-{variant|facet} --no-refresh options
7173792 pkg doesn't auto-refresh previously used and disabled sysrepo publishers
thanks,
ed
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
image.py:
977: Why's it necessary to set the publisher's meta root here?
Alternatively, why do only these publishers need their meta root set?
978: Personally, I think this line really belongs in
imageconfig.__merge_publishers. Couldn't we add it in as part of the
step of generating modified_pubs around line 1286 in imageconfig.py?
t_pkg_sysrepo:
456: Why aren't we destroying the image here any more? After this loop
is finished, we'll now have an extra random image laying around on disk
(which may confuse developers using the -a option, though I'd need to
see what kind of archive actually is produced).
You might consider adding tests where the user changes the value of the
image-property "use-system-repo" from true to false, then back to true,
and while it was set to false, origins were added or removed or packages
were published to configured publishers.
Thanks,
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
