On 08/17/12 16:23, Tim Foster wrote:
hi there,
I've got a short code review here which fixes how pkglint deals with
'legacy' actions.
In the past, when encountering a legacy action, we have a check that
follow renames starting at the package pointed to by the 'pkg'
attribute of the legacy action, ensuring that the rename chain ends up
with the package containing the legacy action being installed.
This check got upset by the SUNWbip -> network/ping, network/ftp
refactoring, along with the introduction of the
pkg:/compatibility/packages/SUNWbip package, and this putback fixes it.
Comments would be most welcome, I'd really like this to make build
23, as it's causing RE some grief.
https://cr.opensolaris.org/action/browse/pkg/timf/pkglint-legacy/pkglint-legacy-webrev/
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
engine.py:
nit 1029/1030: extra new line?
1024/1026: What happens target.get_name doesn't match any package? It
looks to me like self.get_manifest will return None and then we'd get an
attribute error on line 1026.
pkglint_action.py:
Maybe it's just that I don't really grok what the legacy action is
doing, but this comment doesn't make much sense to me. I think breaking
it up into 4 sentences, one per parameter might make things clearer.
A more general question:
With a legacy action, are we guaranteed that the target will be a base
name? Could we (in the future perhaps) have a legacy action whose target
was something like "foo/bar"? In that case, I'm a bit concerned about
line 1022 of engine.py. If that's simply not something we care about
now, then feel free to ignore it :)
t_pkglint:
Line 2987 refers to "renamed_old" and "compat_renamed_old" but the
manifests read on 2993 are "renamed_old" and "compat_legacy" (and I
don't actually see compat_renamed_old" mentioned after that). Is the
comment wrong?
3005: commented line?
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
