On 08/28/12 04:38 PM, Tim Foster wrote:
On 08/29/12 11:34 AM, Erik Trauschke wrote:
cli.t_pkg_help.py TestPkgHelp.test_help_character_encoding

Does it fail, or skip? It should skip if the correct locale facet isn't
enabled on your test box, from the code:

It fails:
======================================================================
FAIL: cli.t_pkg_help.py TestPkgHelp.test_help_character_encoding
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./pkg5unittest.py", line 645, in run
    testMethod()
File "./api/../cli/t_pkg_help.py", line 130, in test_help_character_encoding
    self.assertEqual(cmd_line, file_line)
AssertionError: u'Usage:' != u'\u4f7f\u7528\u65b9\u6cd5:'

# ----------------------------------------------------------------------

# Ran 797 tests in 659.498s - skipped 0 tests.



105 m = re.search(r"ja_JP.eucJP", line)
106 if not m:
107 raise pkg5unittest.TestSkippedException("The "
108 "test system must have the ja_JP.eucJP locale "
109 "installed to run this test.")
110


I still think it'd be great if we reported skipped tests if we weren't
running in the C locale, but otherwise, the initial warnings are good
too (gives the user a chance to ^C if they read them in time)

Actually, I catch the "not root" warning all the time since non of my machines is so fast that it just scrolls it out of the screen too quickly. And usually people look at the screen output just after they started something. At least I do.

Erik


cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to