On 08/29/12 17:41, Edward Pilatowicz wrote:
ugh.  that's ugly.  nice job figuring this out.

the fix looks good to me, but i wonder if we could have caught this
automatically (and perhaps prevent bugs like this in the future) by
making the values in self.__possible_dict into immutable lists?  (
__assign_fmri_ids() is the only place where self.__possible_dict values
get updated.)

That seems like a fine idea in the longer-term, but not something I want to change at this moment :-)

I'll file a bug about having the solver use more immutable data structures where possible. We already want that for PkgFmri.

-Shawn

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to