On 10/17/12 12:19, Thejaswini wrote:
Hi All,
Please review the fixes for the below CR's:
1. 7197510: pkgrecv error handling traces back:
http://monaco.us.oracle.com/detail.jsf?cr=7197510
2. 7197865: pkgrecv dies with ENOSPC:
http://monaco.us.oracle.com/detail.jsf?cr=7197865
Webrev @:
https://cr.opensolaris.org/action/browse/pkg/tk241774/7197510/webrev/
In general these changes LGTM. just small nits :
- src/pull.py
950 + __ret = main_func()
indentation is incorrect
1005 + cleanup(False)
you can use cleanup() (i.e. without 'False' as arg) as False being
the default value.
Thanks,
Saurabh
The unit testing has been done.
Also , make packages and make tests is clean.
Thanks,
Thejaswini
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
--
Saurabh Vyas
Solaris Install Group,
Revenue Product Engineering (RPE), Systems
ORACLE India | Off Langford Road | Bangalore | 560025
|Bangalore |
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to
developing practices and products that help protect the environment
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
