Thanks Tim for reviewing!!
I will make the necessary changes and send the webrev.
Thanks
Oracle
Thejaswini K
Revenue Product Engineering (RPE), Systems
Phone: +91 8066927709 | Mobile: +91 9663324594
ORACLE India | Off Langford Road | Bangalore | 560025
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to
developing practices and products that help protect the environment
On 11/22/12 09:29, Tim Foster wrote:
On 11/ 8/12 07:45 PM, Thejaswini wrote:
https://cr.opensolaris.org/action/browse/pkg/tk241774/15744194-rev02/webrev/
Note: I have included the fix to bug "15847480 Space required after
line 2779 in api_errors.py"
I've reviewed all of this, and it looks mostly ok.
Could you add a comment to src/svc/pkg-update.xml explaining what the
update pg is for, something like:
<!-- Create a property group to allow the update service to record the
time it last ran. See /usr/lib/update-manager/update-refresh.sh -->
Also, with the changes in src/tests/cli/t_pkg_search.py, could you add
some code to actually verify that what you searched for was actually
shown in the stdout of the 'pkg search' command.
Otherwise, all looks good - I tested the changes locally, and they
worked fine.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
