On 11/29/12 07:08 PM, Tim Foster wrote:
Hi there,

I've got a webrev of the http-depot work ready for review, if anyone has
bandwidth:

https://cr.opensolaris.org/action/browse/pkg/timf/http-depot-webrev-0/http-depot-webrev/

src/util/apache2/depot/depot.conf.mako:
40: might want to consider "NoDecode" instead of "On" here. "On" might mess up slashes in searches (unless search is redirected already before that, which I think it isn't if I read this right)

106: will %(repo_prefix)s always have a trailing / ? Otherwise the concatenation might be incorrect.

src/util/apache2/depot/depot_httpd.conf.mako:
341: how does that work? You are using the pkg and manifest directory as an apache cache which has a different format?


src/util/apache2/depot/logs/access_log
src/util/apache2/depot/logs/error_log:
  are they supposed to be in the wad?


Erik




Everything is pretty much as per the original proposal I sent out a few
months ago (
https://cr.opensolaris.org/action/browse/pkg/timf/apache-depot-proposal/apache-depot.html
) with a few exceptions:

* it's called http-depot now, instead of apache-depot[1]

* we have the concept of a 'repository prefix', essentially separating
the web server namespace into different repositories - this turns out to
be much easier to read than scattering SHA-1 hashes throughout the
webserver namespace.

By default, the repository prefix maps directly to the SMF instance name
of the corresponding pkg:/application/pkg/server instance, though you
can also run pkg.http-depot with -R options, making it to ignore SMF.

* The root of the http-depot serves a page showing a list of all
repositories available, and links to the publishers inside that repository

* the mod_wsgi application that serves search/* requests now also serves
the BUI application, including info, p5i and admin requests


I've included a draft man page in the workspace, but I'll happily remove
that prior to putback and file a docs bug to get that cleaned up. For
convenience, I've attached a plaintext rendering of the man page.

Comments or questions would be most welcome,

cheers,
tim


[1] I'm happy to bikeshed on the name, so long as there's beer involved :-)


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to