Hi folks,
so this is the API part of the basic options checking for input parameters.
As per our discussions, it only does very basic checking but generates
proper exceptions for invalid FMRIs, invalid repo URIs and invalid
option combinations (very limited).
It also asserts the type of input parameters.
Please have a look at the nullable column. Not sure if this is something
useful but I figured it might be a good idea. I set it based on default
values in the planning functions, it might be that some need changing.
For the FMRI validation step I'm currently generating a
PlanCreationException to keep things like they were before. However, I
could imagine an FmriError would also be appropriate but would require
changes in the client. I'm fine either way.
https://cr.opensolaris.org/action/browse/pkg/erisch/15981296/webrev/
I filed an additional bug for this cr. For the other bug I will
implement the options checking in a common place, based off of my first
approach. This doesn't move anything into the API but allows 3rd party
clients to use the CLI options including their verification steps.
Erik
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
