On 12/18/12 12:09 PM, Shawn Walker wrote:
On 12/10/12 14:27, Tim Foster wrote:
https://cr.opensolaris.org/action/browse/pkg/timf/pkglint-access-refmf/pkglint-access-refmf-webrev
Thanks for the review!
src/modules/lint/engine.py:
line 693: s/from/using/ ?
Good point. I've changed the comment on line 796 to say "using" rather
than "in" where appropriate also.
I assume this means that any repositories
configured in the reference image are valid sources for manifest
retrieval? Not just packages installed in the reference image?
That's right. pkglint never installs any packages in any of its images,
it just uses them as a means to retrieve manifests from any configured
origins.
In fact it can only configure one origin per lint-session for either the
reference or lint repository, which is RFE 15707738 (though I believe
that if you manipulate the various images it uses under the hood using
'pkg set-publisher', it will work just fine, because ultimately, it's
just an API consumer)
Either way, there's more work needed here to verify that's the case, and
add the support properly, or document how users should set publishers
accordingly. I'm not wild about adding the myriad of 'set-publisher'
options, like --search-before, etc. to pkglint itself, but it hasn't
come to that yet.
lines 802-803: Wrap the string, not the paren :-)
line 805: a newline after this would be nice
Yep, fixed.
Thanks again for the review.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
