On 01/25/13 15:19, Bart Smaalders wrote:
< I actually got time to write some code again>
We're adding support for revert-tags on directories to
delete unpackaged content. This is useful for cleaning
up log files, etc. when reverting a system to a clean state.
revert-tag=daleks=terminate.* When pkg revert --tagged daleks
is run, any files or directories (recursively) that match
"terminate.*" and are not packaged in the tagged directory
are removed. This doesn't work on mount points or across
file system mounts.
https://cr.opensolaris.org/action/browse/pkg/barts/directory_revert_tags/
=============================================================
src/man/pkg.1:
copyright update
line 1394: stray whitespace at end of line?
line 1409: s/unpacked/unpackaged/ ?
line 1409: s/See /See "File Actions" in the /
=============================================================
src/man/pkg.5:
copyright update
line 238: s/ This attribute/ This attribute/
line 244: This line may need updating to include "revert-tag" and to
see "File Actions" for details. The current text seems to imply that
only a few of the file action tags are permitted.
=============================================================
src/modules/client/imageplan.py:
copyright update
line 769: Shouldn't the len() != 2 be first? Faster anyway...
lines 771, 835: s/f,m/f, m/
line 833: if revert_dirs is not being modified during iteration, it
is more efficient to simply "for f, m in revert_dirs:" as calling
.keys() returns a private copy of the list of keys.
lines 864, 892: extra newline
line 871: s/# if/# If/
line 885: s/# a/# A/
line 891: de-indent 4 spaces
line 907: This will construct a new list; since you don't actually
need a new list, you could also do:
for name in itertools.chain(dirnames, filenames):
...but this may be premature optimisation ;-)
line 916: s/w/W/
line 918: missing '.'
line 3256: what changed here?
=============================================================
src/tests/cli/t_pkg_revert.py:
copyright update
line 129: insert newline before
line 212: change # into """ """ docstring
line 234: s/unpacked/unpackaged/ ?
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
