On 02/01/13 11:25, Edward Pilatowicz wrote:
hey all,

i have a small bugfix (9 lines of actual code) that speeds up noop pkg
operations:

        https://cr.opensolaris.org/action/browse/pkg/edp/pkg.lisyncfast/webrev/
        16269426 noop pkg operations are slow

i benchmarked the fix on my desktop with the following command:

        ptime pkg install --no-refresh -n osnet-incorporation

without the fix execution time was 1 min and 24 sec, with the fix
execution time was 12 seconds.

more details about the analysis/fix are in the bug report.

ed

Hi Ed -

Nice find...

imageplan.py:


line 2209:  nit: s/# if/# If
line 2213:  nit: s/todo/to do

line 2219 - 2221:

        Seems like return defaultdict(set, self.pd._cfg_mediators)

would achieve the same thing, no?

if you wish, you could indent 2983 through 3008  one level right,
but w/ our indent level that's gonna cause problems.

= Bart



--
Bart Smaalders                  Solaris Core OS
[email protected]       http://blogs.oracle.com/barts
"You will contribute more with Mercurial than with Thunderbird."
"Civilization advances by extending the number of important
 operations which we can perform without thinking about them."
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to