Hi there,
On 02/ 5/13 09:21 PM, Thejaswini wrote:
The below webrev contains the fix for the following bugs:
15771543 set-publisher -p error message difficult to understand when publish
- The fix is that the error message is made more clear.
15769004 pkg unset-publisher could use a progress tracker
- Here I have added progress tracker logs which would appear
while deleting the publisher metadata.
https://cr.opensolaris.org/action/browse/pkg/tk241774/15771543/
src/client.py
line 4504, it's ok to delete this blank line I think.
src/modules/client/progress.py
line 1205, why are we calling a method "_load_metadata_output" when
we're actually removing metadata. I think it would make more sense to
call the method on line 1960, 2355 "_remove_metadata_output"?
line 1962, you don't need the continuation '\' character because you're
using them within parentheses.
General: how long does metadata removal usually take? Rather than a single:
"Removing metadata ... done"
prompt, would it be useful to have a rolling progress, showing how we're
doing when removing bits of metadata instead? eg.
"Removing metadata 1/100"
In the case of the example in the bug report, 16 minutes is a very long
time to be waiting with no feedback other than, effectively "I'm busy".
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
