On 02/ 9/13 01:49 PM, Erik Trauschke wrote:
This is a very small change to prevent the depot server BUI from failing
when there are version-less incorporation dependencies in a package.
It's two lines of code change and a simple test case.
https://cr.opensolaris.org/action/browse/pkg/erisch/16304629/webrev/
This looks good.
Could you remove the bugid from the comment in src/modules/api.py on
line 193: the bug database is the right place to document bugs, not the
source code. The rest of that comment is fine.
It's probably ok to leave it in the unit test though, but it's up to you
- we're a bit inconsistent in how we deal with bugids in unit tests.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
