On 02/21/13 01:05 PM, Shawn Walker wrote:
Greetings, The following webrev adds a '-t' option to pkgdiff for specifying which action types to compare: 16383458 pkgdiff should support filtering on action type like pkg contents While this could be done now by using pkgmogrify to generate temporary manifests to compare first, comparing a single type of actions is common enough (think depend actions) that adding a filtering option seemed the right thing to do. webrev: https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-16383458/webrev/
It seems to me the test case of comparing tree10, tree20 and tree30 is not strict enough. The first two are completely different so if you filter doesn't work it wouldn't make a difference. Tree20 and tree30 are essentially the same so even if you don't filter on a particular action type it should succeed, even if the filter doesn't work at all.
I think it would make sense to have maybe another manifest which has the same file actions but different dir actions and check if it they are equal for file actions but unequal for dir actions.
Erik _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
