On 03/ 5/13 01:12 PM, Tim Foster wrote:
On 03/ 6/13 08:31 AM, Erik Trauschke wrote:
https://cr.opensolaris.org/action/browse/pkg/timf/mirror-cache/mirror-cache-webrev/
173,175:
what happens if you run smf_schedule_updates() before
update_repository() (which I think will always happen when you run
start())? Isn't SAVED_IFS empty in this case?
Och, good catch, thanks. I should be setting SAVED_IFS to $IFS here,
before setting it to the comma.
219,220:
you put the arg for repo in quotes but not the one for pub. Is there
any reason we need quotes for one and not the other?
Yep, pkg(5) publisher names can't contain spaces, but paths to repos can.
Oh, I always forget that there are still people who use spaces in path
names. Reminds me I have to finish the review for Shawn wad which fixes
dir actions with multiple spaces in path names.
+1 for your change
Erik
Thanks for the review, much appreciated!
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
