On 03/20/13 11:07 AM, Erik Trauschke wrote:
https://cr.opensolaris.org/action/browse/pkg/timf/sysrepo-resilient-config/sysrepo-resilient-config-webrev/
lgtm
Thanks for taking a look!
https://cr.opensolaris.org/action/browse/pkg/timf/add-cronjob/add_cronjob-webrev
154: nit: /contains/contain/
Yep, I'll fix that.
you're testing only for the existence of ${CMD} in the whole crontab.
How likely is it that this test might find something the user put in
there (or asked differently, how unique is ${CMD})?
Sure - I tried to address that in the comment at the top of
add_cronjob(). In this case, $CMD is unique in that it contains the
full SMF FMRI of the service we're looking to add/remove, eg.
"/usr/sbin/svcadm refresh svc:/application/pkg/mirror:default"
It specifically doesn't include the rest of the cron entry (namely the
cron schedule) because that can change as the user modifies SMF properties.
For the consumers of this function, pkg/update and pkg/mirror, this is
enough I think. Yes, the pkg/update service would potentially clash if
we had more than one instance of the service running, since the command
it uses is:
"/usr/lib/update-manager/update-refresh.sh"
but that doesn't seem likely (and I hope we get to nuke pkg/update real
soon now anyway - its use of root's crontab is disturbing..)
Thanks for looking at these webrevs, much appreciated!
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
