Barry deFreese wrote: Note: I will revert the problematic changes unless you answer this mail[*]!
> Add desktop file. Stop binary from being stripped > Modified: packages/trunk/gravitywars/debian/rules > - -$(MAKE) clean > + [ ! -f Makefile ] || $(MAKE) clean it would be nice to mention in the commit log such changes, too > - install -m 755 -s GravityWars101 \ > + install -m 755 GravityWars101 \ I wonder if when nostrip is *not* provided if this is fixed. Did you test that? Also, wouldn't using dh_install be a better solution instead of mixing debhelper stuff with non-debhelper stuff? > `pwd`/debian/gravitywars/usr/games/gravitywars > install -m 644 debian/gravitywars.xpm \ > `pwd`/debian/gravitywars/usr/share/games/gravitywars/ > + > + # Install desktop file > + install -D -m 644 debian/gravitywars.desktop > debian/gravitywars/usr/share/applications/gravitywars.desktop > + [*] as discussed on the list, we need more review and when comments are not addressed I will revert them; if the changes are important, explanation shall follow, if not, the changes will be reverted. -- Regards, EddyP ============================================= "Imagination is more important than knowledge" A.Einstein
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Pkg-games-devel mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/pkg-games-devel
