On Fri, Jun 22, 2018 at 9:29 PM, Tong Sun <pkgoyq....@neverbox.com> wrote: > Hi all, > > Thanks to Anthony help. I've fixed all known problem to the first Go > package I'm packing. > > Would someone do a final check on it before I upload it as new please?
Not a comprehensive check, but I noticed one thing in the Build-Depends and Depends fields of your debian/control: "golang-x-text-dev" is a deprecated transitional package and will be removed eventually. Use "golang-golang-x-text-dev" instead. > Especially, Clément & Martín, > > Would you check that I'm following the new workflow correctly please, > as Anthony himself is still using the old workflow. Your package does not yet meet the first criteria of the new workflow, namely: 1.1. “upstream” branch should contain upstream git history Compare https://salsa.debian.org/go-team/packages/golang-github-danverbraganza-varcaser/commits/upstream with https://salsa.debian.org/go-team/packages/golang-github-wellington-go-libsass/commits/upstream which I packaged and uploaded, using the new workflow, a few days ago. ;-) If you want to start out with a with a pure, perfect "new workflow" package, I recommend that you fix your upstream branch (and hence debian/sid too) before the first upload. In my opinion, this is one of the most challenging part of the "new workflow". This "upstream branch containing upstream git history" is not new and not unique to the pkg-go team, but is, IMHO, not very well documented and somewhat difficult to maintain consistently due to the lack of detailed guide or automated tools doing so at this point in time. There are quite a few Go packages which started out with full upstream git history, but ended up with just a bulk import of release tarballs in later versions, for better or for worse. If I understand correctly, the maintainer needs to to add a remote to the original repository on GitHub (for example), and every time he/she wants to upload a new version, consistently run "git fetch github", then use "gbp import-orig" carefully with the correct "--upstream-vcs-tag", and then the upstream branch will be automatically kept correct That is being discussed in the feature request to gbp at https://bugs.debian.org/812721 with talks of adding a "gbp import-git" or "gbp import-ref" command. As I mentioned earlier, the infrastructure (including essential tools like gbp) are not quite ready for the new workflow to be used consistently by everyone, hence it is not mass implemented yet across all packages. But indeed, I am still quite new to this, so I'd better let the others speak. Martín, could you please give Tong a step-by-step instruction to fix his repository so it starts out as a clean implementation of the new workflow? Many thanks! Cheers, Anthony _______________________________________________ Pkg-go-maintainers mailing list Pkg-go-maintainers@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-go-maintainers