Your message dated Fri, 01 Sep 2023 06:08:21 +0000 with message-id <e1qbxkp-006esc...@fasolo.debian.org> and subject line Bug#1050944: fixed in jtreg6 6.2+1-2 has caused the Debian Bug report #1050944, regarding jtreg6: please make the build reproducible to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 1050944: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050944 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: jtreg6 Version: 6.2+1-1 Severity: wishlist Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: timestamps X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Hi, Whilst working on the Reproducible Builds effort [0], we noticed that jtreg6 could not be built reproducibly. This was caused by two issues: 1. Due to the moving from Ant's build.xml to the Makefile-based build, the build date embedded into the MANIFEST.MF file was being generated from the system/build time. This requires a patch to the build system to use SOURCE_DATE_EPOCH if available. (This hunk can go upstream.) 2. The jtreg.jar file was being generated with 444 (read-only) permissions. This meant that strip-determinism could not fixup the file modification times of the files within that archive. It was actually printing: "dh_strip_nondeterminism: warning: Ignoring unwritable file: jtreg.jar". A patch for both issues is attached. [0] https://reproducible-builds.org/ Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `---- a/debian/patches/reproducible-build.patch 1969-12-31 16:00:00.000000000 -0800 --- b/debian/patches/reproducible-build.patch 2023-08-31 10:04:38.116032765 -0700 @@ -0,0 +1,29 @@ +Description: Make the build reproducible +Author: Chris Lamb <la...@debian.org> +Last-Update: 2023-08-31 + +--- jtreg6-6.2+1.orig/make/Rules.gmk ++++ jtreg6-6.2+1/make/Rules.gmk +@@ -55,6 +55,13 @@ $(CLASSDIR) $(BUILDDIR) $(BUILDDIR)/test + # default copyright; override as necessary + JAR_COPYRIGHT = -C $(TOPDIR) COPYRIGHT + ++DATE_FMT = %B %d, %Y ++ifdef SOURCE_DATE_EPOCH ++ BUILD_DATE ?= $(shell LC_ALL=C date -u -d "@$(SOURCE_DATE_EPOCH)" "$(DATE_FMT)" 2>/dev/null || LC_ALL=C date -u -r "$(SOURCE_DATE_EPOCH)" "$(DATE_FMT)" 2>/dev/null || LC_ALL=C date -u "$(DATE_FMT)") ++else ++ BUILD_DATE ?= $(shell date "$(DATE_FMT)") ++endif ++ + $(IMAGES_DIR)/%.jar: pkgsToFiles.sh + $(RM) $@ $(@:$(IMAGES_DIR)/%.jar=$(BUILDDIR)/jarData/%) + $(MKDIR) -p $(@D) +@@ -68,7 +75,7 @@ $(IMAGES_DIR)/%.jar: pkgsToFiles.sh + echo "$(@F:%.jar=%)-Build: $(BUILD_NUMBER)" ; \ + echo "$(@F:%.jar=%)-BuildJavaVersion: `$(JDKJAVA) -fullversion 2>&1 | awk '{print $$NF}' | \ + sed -e 's|^"\(.*\)"$$|Java(TM) 2 SDK, Version \1|'`" ; \ +- echo "$(@F:%.jar=%)-BuildDate: `/bin/date +'%B %d, %Y'`" ; \ ++ echo "$(@F:%.jar=%)-BuildDate: $(BUILD_DATE)" ; \ + ) \ + > $(@:$(IMAGES_DIR)/%.jar=$(BUILDDIR)/jarData/%/manifest.txt) + sh pkgsToFiles.sh $(CLASSDIR) $($(@F:%.jar=PKGS.JAR.%)) > $(@:$(IMAGES_DIR)/%.jar=$(BUILDDIR)/jarData/%/includes.txt) --- a/debian/patches/series 2023-08-31 09:50:06.571624952 -0700 --- b/debian/patches/series 2023-08-31 10:04:37.028021356 -0700 @@ -2,3 +2,4 @@ launchers.patch add-jcommander-to-classpath.patch add-logger-to-classpath.patch +reproducible-build.patch --- a/debian/rules 2023-08-31 09:50:06.571624952 -0700 --- b/debian/rules 2023-08-31 10:08:31.850276393 -0700 @@ -33,3 +33,6 @@ # Generate the manpages JT_HOME=./dist/jtreg/lib/ help2man --name="Regression Test Harness" --help-option="-help all" dist/jtreg/bin/jtdiff > jtdiff.1 JT_HOME=./dist/jtreg/lib/ help2man --name="Regression Test Harness" --help-option="-help all" dist/jtreg/bin/jtreg > jtreg.1 + +execute_before_dh_strip_nondeterminism: + find debian/ -type f -name jtreg.jar -print0 | xargs -0tr chmod +w
--- End Message ---
--- Begin Message ---Source: jtreg6 Source-Version: 6.2+1-2 Done: tony mancill <tmanc...@debian.org> We believe that the bug you reported is fixed in the latest version of jtreg6, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 1050...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. tony mancill <tmanc...@debian.org> (supplier of updated jtreg6 package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Thu, 31 Aug 2023 22:16:15 -0700 Source: jtreg6 Architecture: source Version: 6.2+1-2 Distribution: unstable Urgency: medium Maintainer: Debian Java Maintainers <pkg-java-maintain...@lists.alioth.debian.org> Changed-By: tony mancill <tmanc...@debian.org> Closes: 1050944 Changes: jtreg6 (6.2+1-2) unstable; urgency=medium . * Team upload. * Apply reproducible builds patch (Closes: #1050944) Thank you to Chris Lamb and Vagrant Cascadian * Use debhelper-compat 13 * Use DEB_VERSION_UPSTREAM to parse VERSION and BUILD_NUMBER in d/rules Checksums-Sha1: cb9bafb977ab42892ecdc74140b52cae9a192451 2140 jtreg6_6.2+1-2.dsc bcb63d4134a94145e7f0bd2c09abbd09b00da752 7464 jtreg6_6.2+1-2.debian.tar.xz 40f97d439e058eba56c8e93c2887a01a030348cf 12509 jtreg6_6.2+1-2_amd64.buildinfo Checksums-Sha256: 5574b5a0ca782e5ed7b8fe550084db76b23eee570e1df0bccadd78857ca09f57 2140 jtreg6_6.2+1-2.dsc ac8ea415943f3e4ab3155464771844f60ebd0a8d8e83d5b2e3bf0f2808f41188 7464 jtreg6_6.2+1-2.debian.tar.xz b8665f8f5775422781a32dbb153ce50fcf3fb554d5e00cd7736e7f935247dc64 12509 jtreg6_6.2+1-2_amd64.buildinfo Files: 954d3d7f889c288a567236a1e1e497e1 2140 java optional jtreg6_6.2+1-2.dsc e59717e96c3b2cca2abf48a4d9d95826 7464 java optional jtreg6_6.2+1-2.debian.tar.xz 64ea3b929583f1ad6f1988136457c177 12509 java optional jtreg6_6.2+1-2_amd64.buildinfo -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEE5Qr9Va3SequXFjqLIdIFiZdLPpYFAmTxdrgUHHRtYW5jaWxs QGRlYmlhbi5vcmcACgkQIdIFiZdLPpYSlw//agym2sesGVZJxhX2xG96iFWUAo/r /PHrET2c1zNpzd9Et9WjyE4NUMxFTQQSJgCWzefnMbwZX4rHBw3TbmX6QMMBJzOp LCn1Kq+gs0HYEclNvVn5LtT8eIzDaZ0Vk1zYPzN/2XQNc8wzb0sJ1ah2O84iU45z kGiXe5NWNVdUeSdNoBocJQ2BZikWgJ1q3li35YhSyVbOsgt9rfrgKwSPa/AXvkTQ KinUhVeNejUNQsNpYHHfM0wNaaSJ60JrYeJeStKvsBtIDkO78+xhtHDXO6qhynIU 0vfxGNFAgTfj+qcTePzW2eCXjy/eIt0aawstVVFrFf6N9rnUk6jtnGCiw91cwJD2 g0UWx2Ewdl87F0fiG+84qfv4HqpEoMc9ZAGLWj/2KI/Bpk6fJOJsDU6OB/x6Uxy6 Go+CtlDIep7i/wYimqprclmSLANkUdnzUkenepUJKbufQxv5ovaal8PBcnykmNxV M806Ng1CVTST5vmVvFDi3Vjg9S3MXKAVYMLxd03/Wa4siOugANEl10xJBszIMURM 3S+/ICIy12F9KnJfY2GS4ZZ4ASkJTTtua/wgYAvTtS+MvU/IbrEORFHlFsvTyHqP 6fRTGiMa3jFyqOqTlvuKv+DnVcAI5U5maS6U1GTuFmiYuDu0dL1zf0I6OzXWT5Ef vpEn20VLJwRrS+w= =yyBu -----END PGP SIGNATURE-----
--- End Message ---
__ This is the maintainer address of Debian's Java team <https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-java-maintainers>. Please use debian-j...@lists.debian.org for discussions and questions.
