Your message dated Wed, 08 Jun 2011 22:34:36 +0000 with message-id <e1qurke-0006gn...@franck.debian.org> and subject line Bug#628693: fixed in maven-debian-helper 1.4.3 has caused the Debian Bug report #628693, regarding InstallDocMojo.java: installs javadoc .jar file with incorrect packagePath to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 628693: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=628693 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: maven-debian-helper Version: 1.4.2+nmu2 Severity: normal Tags: patch When the install-doc goal is invoked the javadoc .jar file get placed in debian/null instead of debian/libfoo-java-doc this results in the javadoc .jar not reaching the binary package and a problem in debian/rules clean. The source of the problem (see provided patch) is that in InstallDocMojo.java protected String packagePath() { if (useMavenRepoLocal) { return mavenRepoLocal.getAbsolutePath(); } else { return getDebianDir() + "/" + getDestPackage(); } } the getDestPackage() function returns "null" because the destPackage attribute is not initialised (it is only initialised inside the pom_clean target in SystemInstallMojo.java). I propose to substitute it with the debianPackage property. -- System Information: Debian Release: 6.0.1 APT prefers stable APT policy: (500, 'stable') Architecture: i386 (i686) Kernel: Linux 2.6.32-5-686 (SMP w/2 CPU cores) Locale: LANG=es_ES.UTF-8, LC_CTYPE=es_ES.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages maven-debian-helper depends on: ii default-jdk 1:1.6-40 Standard Java or Java compatible D ii libmaven-clean-plugin-java 2.3-3 Maven clean plugin ii libmaven-compiler-plugin-java 2.0.2-4 Maven compiler plugin ii libmaven-jar-plugin-java 2.2-4 Maven Jar plugin ii libmaven-resources-plugin-jav 2.3-5 Maven resources plugin ii libmaven-site-plugin-java 2.1-1 Maven Site Plugin for generating a ii libplexus-velocity-java 1.1.7-3 Plexus component interface to velo ii libsurefire-java 2.4.3-3 Surefire test framework for Java ii maven-repo-helper 1.5.1+nmu1 Helper tools for including Maven m ii maven2 2.2.1-5 Java software project management a ii velocity 1.6.2-4 Java-based template engine for web Versions of packages maven-debian-helper recommends: ii apt-file 2.4.0 search for files within Debian pac ii devscripts 2.10.69+squeeze1 scripts to make the life of a Debi ii subversion 1.6.12dfsg-5 Advanced version control system Versions of packages maven-debian-helper suggests: ii libmaven-javadoc-plugin-java 2.6.1-1 Maven Javadoc Plugin -- no debconf informationdiff -ur maven-debian-helper-1.4.2+nmu1/maven-debian-plugin/src/main/java/org/debian/maven/plugin/InstallDocMojo.java maven-debian-helper-1.4.2+nmu2/maven-debian-plugin/src/main/java/org/debian/maven/plugin/InstallDocMojo.java --- maven-debian-helper-1.4.2+nmu1/maven-debian-plugin/src/main/java/org/debian/maven/plugin/InstallDocMojo.java 2010-12-05 18:23:07.000000000 +0100 +++ maven-debian-helper-1.4.2+nmu2/maven-debian-plugin/src/main/java/org/debian/maven/plugin/InstallDocMojo.java 2011-05-31 13:25:57.000000000 +0200 @@ -53,12 +53,20 @@ /* returns e.g. $CURDIR/debian/libfoobar-java */ + /** + * If true, use local Maven repository for installation + * + * @parameter expression="${debian.package}" + */ + private String debianPackage; + + protected String packagePath() { if (useMavenRepoLocal) { return mavenRepoLocal.getAbsolutePath(); } else { - return getDebianDir() + "/" + getDestPackage(); + return getDebianDir() + "/" + debianPackage; } }
--- End Message ---
--- Begin Message ---Source: maven-debian-helper Source-Version: 1.4.3 We believe that the bug you reported is fixed in the latest version of maven-debian-helper, which is due to be installed in the Debian FTP archive: maven-debian-helper_1.4.3.dsc to main/m/maven-debian-helper/maven-debian-helper_1.4.3.dsc maven-debian-helper_1.4.3.tar.gz to main/m/maven-debian-helper/maven-debian-helper_1.4.3.tar.gz maven-debian-helper_1.4.3_all.deb to main/m/maven-debian-helper/maven-debian-helper_1.4.3_all.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 628...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Damien Raude-Morvan <draz...@debian.org> (supplier of updated maven-debian-helper package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Thu, 09 Jun 2011 00:11:08 +0200 Source: maven-debian-helper Binary: maven-debian-helper Architecture: source all Version: 1.4.3 Distribution: unstable Urgency: low Maintainer: Debian Java Maintainers <pkg-java-maintainers@lists.alioth.debian.org> Changed-By: Damien Raude-Morvan <draz...@debian.org> Description: maven-debian-helper - Helper tools for building Debian packages with Maven Closes: 613364 628272 628693 628703 629356 Changes: maven-debian-helper (1.4.3) unstable; urgency=low . * DependenciesSolver: Don't use Properties.store() method since it escape some chars (like " >\=") from variables. Replace it with simple FileWriter. Closes: #628272. * SysInstallMojo: Send "--keep-elements" flag to POMCleaner if its set in <pkg>.poms file. Thanks to James Page <james.p...@canonical.com>. Closes: #613364 * mh_resolve_dependencies: Always launch Maven in offline mode with --offline option (as already done on mh_make). Closes: #629356 * SysInstallDocMojo, SysInstallMojo: Drop initProperties method and only rely on Maven mojo attributes injection of "debianPackage" and "destPackage". Closes: #628693. * mh_resolve_dependencies: New --javadoc param, send from maven.mk CDBS file to automatically compute Javadoc dependencies when there is some *-doc package. Closes: #628703. Checksums-Sha1: a2f8649c7afcd3c1d5845f685c9ad2c2ca4cbeca 1980 maven-debian-helper_1.4.3.dsc 746af9e9d8dd076e0a3d393481be7c401578f162 67710 maven-debian-helper_1.4.3.tar.gz 2f965f6afe52f71736f0e4bb242cf6b9c9e08fd9 86456 maven-debian-helper_1.4.3_all.deb Checksums-Sha256: d615b956f6a1a6dcf11679996ca7658cd065b9b433a5a064f522adf9d97e5460 1980 maven-debian-helper_1.4.3.dsc 84f84d86259372209bbef16e517db058985722467cf271478f8ee2672cdf8aa1 67710 maven-debian-helper_1.4.3.tar.gz b154cacd84cff9f9117fc7e05332fd9a783724ec6ada538ec3e16aa7b8c08395 86456 maven-debian-helper_1.4.3_all.deb Files: 07edc47bea2be4344eda753ed44dab58 1980 java optional maven-debian-helper_1.4.3.dsc 9591ea1e38b02df73c97399f3a330373 67710 java optional maven-debian-helper_1.4.3.tar.gz 3b9b179275cc169f7e3524415f157747 86456 java optional maven-debian-helper_1.4.3_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJN7/YnAAoJEHXiDM0z50n8EL4P/iw8Pc51hrwWBpH1EhtCOtj7 20U0CU9t0rosH/07Hv4IlSpdqE+mJEx9iPCaY/WhgGUTMGdOEjvXG7zHCKEpGj7p 2b8VdyAy4JJkOXruDjfWs65aazmEPHUcnPsBfsiWqiU0vCPNaD33tokTjhA++xex NnpS/OivpDIwg97ZZQqCiNOba9S7uJJ0WAVeTIyFnmojisSi0x34uBAAdljMmRD7 tQGX8TtGhpme7bpDNI/bAMD/C9GTN3stGAtqWEJHTCkc51Uh+9Zvy5QPD0BlYy38 dRR8Ck8acePovfaKg67h+5qJ6pYTzqRPXrVGNwwg/ecZYK0qvdM7bcLohtMt8qNi D87VrE1fQWCEIOL7i13N4T9enp/CqmESfCY09YBugfor09Bw5Ps4NdtVntCt5CBu h29v1wF2jBGaJrFSjV3zp93W2K6sDnB5/KMsL3Dxrox9w7l0wLkHWg5D2DwhVoW1 Gb6uNPU30J5zH19hw1KHzrRZ6hIovX8GEHT7Gdzaec9fcDKDf0kN0SJyiJSwA4Ls QxzGcabRSRLBGUC5N7zF8drYt3CZpLAx/2zkQ2Pa8s0Fy0g+DnI1nhYx0mNBkf0T Fx/+G5MU41g4ROAx+eesH/Ob+97YUJya6ChSJROAfq1o7kFheGVIraIJXg3b3XUV U7/6MOLUdowXY4G+cAZL =szMK -----END PGP SIGNATURE-----
--- End Message ---
__ This is the maintainer address of Debian's Java team <http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers>. Please use debian-j...@lists.debian.org for discussions and questions.
