Hello,

Le 2018-11-26 03:01, Pirate Praveen a écrit :

You can try using node-neo-async instead for your package. It is
supposed to be a drop in replacement for node-async.

https://tracker.debian.org/pkg/node-neo-async

Thanks for pointing out node-neo-async!

I ran a manual test of the packages included in istanbuljs and most of the test pass, except for the package istanbul-lib-instrument which fails with the error:

Error: Options {"loose":true} passed to /usr/lib/nodejs/babel-preset-env/lib/index.js which does not accept options. (While processing preset: "/usr/lib/nodejs/babel-preset-env/lib/index.js") (While processing preset: "/usr/lib/nodejs/babel-preset-env/lib/index.js")

At first it looks like an incompatibility with some packages but I'll keep looking and try to fix that.

Meanwhile, since the initial goal is to validate node-neo-async instead of node-async, I'd say it's ok with neo-async according to istanbuljs' tests

Testing istanbuljs requires the new package node-memory-streams to be available. Thanks to the Universe (and memory-streams dev), this package can be easily built using Debian's node packages.

Also, there are pretests scripts in istanbuljs packages:
jshint index.js lib/ test/

jshint is not present in Debian, but according to its documentation, jshint is a code quality tool that flags suspicious usage. In that case I would assume upstream released code has been validated, so running jshint during build process isn't necessary.

Also, neo-async package's documentation states that you can use it in standard mode:
var async = require('neo-async');

or in replacement mode:
$ ln -s ./node_modules/neo-async ./node_modules/async
var async = require('async');

I ran my tests in standard mode by replacing in the source files "require('async')" with "require('neo-async')".

In the Debian context, I'd patch the package source to use require('neo-async') when needed instead of building a soft link because otherwise, we couldn't have the packages node-async and node-neo-async at the same time.

I will add all the tests but the one that fails to the node-istanbuljs package and package node-memory-streams as well.

/Nicolas

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Reply via email to