On Tue, Feb 19, 2019 at 1:55 AM, Paul Gevers <elb...@debian.org> wrote:
Hi Pirate,
On 17-02-2019 11:51, Pirate Praveen wrote:
Thanks Paul for testing. The missing dependencies were treated as
external dependencies by rollup (webpack would give an error), would
have worked in node, but not in browser. I embedded the missing
dependencies and also used rollup-plugin-node-resolve to include all
dependencies in the bundle. So please test 2.7.3+dfsg-2 and confirm
if
it is working as expected (for gitlab, I still don't use the
packaged
version, so can't really test now).
I can now see 'function getRgba(string) {' in the built bundle.
Also the file looks quite different, but I guess that is to be
expected
due to build system differences.
As long as it is working as expected, the exact match is not
required.
Each build tool has their on signature styles for bundling.
I went ahead and uploaded your version to my PPA for Ubuntu/Cosmic as
there are multiple people tracking Cacti from there (so it could be
tested). However, it FTBFS with the message below. I expect this is a
versioned dependency issue. Do you happen to know which one or how to
debug it?
rollup itself is an older revision there with unfixed bugs (rollup
0.50.0-1build1 vs 0.50.0-6). And possibly all rollup plugins are older
too.
Paul
https://launchpadlibrarian.net/411721887/buildlog_ubuntu-cosmic-amd64.node-chart.js_2.7.3+dfsg-2~ppa1c_BUILDING.txt.gz
rollup -c debian/rollup.config.js
[!] TypeError: Cannot read property 'declarations' of undefined
TypeError: Cannot read property 'declarations' of undefined
at loop (/usr/lib/nodejs/rollup/dist/rollup.js:2532:26)
at Node.render (/usr/lib/nodejs/rollup/dist/rollup.js:2583:59)
at Module.render (/usr/lib/nodejs/rollup/dist/rollup.js:3187:9)
at orderedModules.forEach.module
(/usr/lib/nodejs/rollup/dist/rollup.js:4883:25)
at Array.forEach (<anonymous>)
at Promise.resolve.then
(/usr/lib/nodejs/rollup/dist/rollup.js:4882:24)
at <anonymous>
at process._tickCallback (internal/process/next_tick.js:188:7)
at Function.Module.runMain (module.js:695:11)
at startup (bootstrap_node.js:191:16)
make[1]: *** [debian/rules:8: override_dh_auto_build] Error 1
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
