On Tue, Apr 28, 2020 at 2:01 am, Nilesh Patra <npatra...@gmail.com>
wrote:
On Tue, 28 Apr 2020, 01:57 Nilesh Patra, <npatra...@gmail.com> wrote:
Hi,
Node-rollup-plugin-replace has build profiles by the name:
<js.transpile.*> as can be seen here [1][2]
This is also the case with a few other node-rollup-plugin-* modules.
While trying to build these with node-babel7, as a part of babel7
transitions, I noticed that these build profiles lead to
lintian error: "Invalid-profile-name-in-source-relation"
On investigating further, I found out that "custom" build profiles
should have name of the form:
"pkg.$sourcepackage.$anything"
This is explicitly mentioned here[3].
After discussing this on IRC, I can think of making Babel the
default transpiler and add build option for Bublé with a !(not).
So this gets picked if passed with DEB_BUILD_PROFILES.
This for instance is the change I wish to suggest:
node-rollup-plugin-buble (>= 4.4~)
<!pkg.node-rollup-plugin-replace.buble>
node-babel7 <pkg.node-rollup-plugin-replace.babel>,
Oops! Correction:
node-rollup-plugin-buble (>= 4.4~)
<pkg.node-rollup-plugin-replace.buble>
node-babel7 <!pkg.node-rollup-plugin-replace.buble>,
Will that be sensible and correct to do?
I would want more "acks" and suggestions on this one.
Since this profile is used in more than one package, may be we can
propose this as a new build profile and may be even have team specific
custom profiles instead of just package specific custom profiles.
I think the following options makes it choose babel by default (if we
go by the profile names chosen by rouca),
node-rollup-plugin-babel (>= 4.4~) <!js.transpile.buble>,
node-babel7,
node-rollup-plugin-buble (>= 0.19.8~)
<js.transpile.buble>
[1]:
https://salsa.debian.org/js-team/node-rollup-plugin-replace/-/blob/master/debian/control#L13
[2]:
https://salsa.debian.org/js-team/node-rollup-plugin-replace/-/blob/master/debian/control#L15
[3]:
https://lintian.debian.org/tags/invalid-profile-name-in-source-relation.html
Thanks and regards,
Nilesh
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
