Quoting Jérémy Lal (2014-04-30 01:43:03) > Le mercredi 30 avril 2014 à 00:46 +0200, Jonas Smedegaard a écrit : >> Hope you agree with the changes I made. Don't hesitate to ask if in >> doubt about any of it. > > Damn copyrighted ICC profile in the png file ! > I didn't build the package before, is this something caught by > copyright-check ? lintian ?
copyright-check wasn't enabled until now. It didn't reveal the actual
problem, only hinted about binary data needing further investigation.
Related to this: DPKG does not like binary data in debian dir, so to
avoid binary noise ending in the copyright_hints file, those files need
to be excluded from copyright-check. Previously I did just that -
relying on then checking manually those exluded files at each source
change. Recently I have begun to instead extending copyright check: See
the packages ruby-compass and ghostscript for the details.
The routine is dead slow currently. Suggestions for optimizations is
appreciated. When polished a bit I may include it in CDBS.
> About package.json:
>
> My idea was to include package.json as part of the module, because
>
> * it is common practice to `require('./package.json').version` inside a
> module, among other things
>
> * eventually, being able to propose a "npm-integration" debian
> package, much like "rubygems-integration", would require access to
> package.json files.
>
> * looking for package.json is hard-wired into nodejs, it's really not
> only about npm.
>
> Granted, if you disagree that won't prevent node-express from running.
>
> If you agree then it's only natural to keep the same relative tree as
> the one expected by package.json
Ok - sounds reasonable that we consistently include package.json, then.
Will you update our wiki page about that?
(...unless anyone else objects, of course)
> (that's why the "lib/" dir was installed in the particular case of
> express, instead of the files within). It saves a patch...
I don't follow: How is install paths related to package.json inclusion?
>>> In case you're missing the time, i can review and upload later today.
>>
>> I suspect you couldn't (or shouldn't) upload yet: At least node-parseurl
>> is missing (I haven't checked further).
>
> Yes, it's waiting in NEW.
Great.
- Jonas
--
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: signature
_______________________________________________ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
