Indeed, it's just that "partially working" was a better outcome than "not working at all".
To explain why it was like that: latest node-nan detects nodejs version to decide wether REPLACE_INVALID_UTF8 is available or not, and i implemented an "API-safe" workaround for v8 that followed the node-nan approach. Now adding that patch to libv8 might break API/ABI. Luckily i have now abi-cc ready to check this. As soon i have i some time i'll add the patch if it doesn't break anything else. 2015-08-31 15:13 GMT+02:00 Ximin Luo <[email protected]>: > Package: libv8-3.14-dev > Version: 3.14.5.8-10 > Severity: normal > > Hi, > > It's not so clear that the recent workaround for REPLACE_INVALID_UTF8 is > such a good idea. In general, this sort of thing has the potential to lead > to security problems. > > nodejs themselves manually patched their bundeled version of v8 > specifically for this bug, see: > > > https://github.com/nodejs/node/commits/v0.10.38-release/deps/v8/include/v8.h > > which points to: > > > https://github.com/nodejs/node/commit/881ac26f27f4ac9585d66c8d8a67d5b246a23d1b#diff-42f385dff7890b3c213d9699bcc350cc > > We should probably import this, instead of the current "fix". > > X > > -- System Information: > Debian Release: stretch/sid > APT prefers testing > APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, > 'experimental') > Architecture: amd64 (x86_64) > Foreign Architectures: i386 > > Kernel: Linux 4.0.0-2-amd64 (SMP w/4 CPU cores) > Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8) > Shell: /bin/sh linked to /bin/dash > Init: systemd (via /run/systemd/system) > > Versions of packages libv8-3.14-dev depends on: > ii libv8-3.14.5 3.14.5.8-10 > > libv8-3.14-dev recommends no packages. > > libv8-3.14-dev suggests no packages. > > -- no debconf information > > _______________________________________________ > Pkg-javascript-devel mailing list > [email protected] > > http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel >
_______________________________________________ Pkg-javascript-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
