Your message dated Sun, 17 Sep 2017 17:36:52 +0000
with message-id <e1dtduy-0002y5...@fasolo.debian.org>
and subject line Bug#872433: fixed in node-resolve 1.4.0-1
has caused the Debian Bug report #872433,
regarding [with solution] Doesn't find modules installed in Debian directories
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
872433: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=872433
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: node-resolve
Version: 1.1.7-2
Severity: grave

Hi,

I'm surprised nobody reported it yet since it basically makes the
package useless as far as I see, but the current node resolve doesn't
find modules installed in Debian directories : while working on another
package, I was surprised that nothing was found. When investigating
using strace, I saw that resolve.sync was always adding "node_modules"
to the paths it tried, so of course it didn't find anything.

I got things to work by editing node-modules-paths.js from:

module.exports = function nodeModulesPaths(start, opts) {
    var modules = opts && opts.moduleDirectory
        ? [].concat(opts.moduleDirectory)
        : ['node_modules'];

to:

module.exports = function nodeModulesPaths(start, opts) {
    var modules = opts && opts.moduleDirectory
        ? [].concat(opts.moduleDirectory)
        : ['node_modules', ''];

ie: I added '' to the list of things to add when generating paths to check.

The following two lines fail with the unpatched node-resolve, and work
with the patched one:
    resolve=require('resolve')
    resolve.sync('resolve/lib/core.js', {basedir: '/usr/lib/nodejs'})
(it should be added in debian/tests/)

I'm part of the Debian Javascript maintainers team so I can add the
necessary patch (with the right header) and test [and probably push
higher upstream version, std-ver and dh] to the git repository to help
if you want -- but I'm no DD so can't upload myself.

Cheers,

Snark on #debian-js

--- End Message ---
--- Begin Message ---
Source: node-resolve
Source-Version: 1.4.0-1

We believe that the bug you reported is fixed in the latest version of
node-resolve, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 872...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Julien Puydt <julien.pu...@laposte.net> (supplier of updated node-resolve 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 16 Aug 2017 19:35:50 +0200
Source: node-resolve
Binary: node-resolve
Architecture: source all
Version: 1.4.0-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Javascript Maintainers 
<pkg-javascript-devel@lists.alioth.debian.org>
Changed-By: Julien Puydt <julien.pu...@laposte.net>
Description:
 node-resolve - Synchronous/Asynchronous require.resolve() algorithm
Closes: 872433
Changes:
 node-resolve (1.4.0-1) unstable; urgency=medium
 .
   * New upstream release.
   * Bump dh compat to 10.
   * Bump std-ver to 4.1.0.
   * Add a patch so node_modules isn't always added to search paths
     (Closes: #872433).
   * Add an autopkgtest to check the patch mentioned above works.
   * Remove build-dep on dh-buildinfo.
   * Bump d/watch to version 4.
Checksums-Sha1:
 53c82c0a9ade6064982f145dc2163b0621ef39f4 2155 node-resolve_1.4.0-1.dsc
 dd39c62d58e4700d7d6fea8284c0af735bc7d519 15710 node-resolve_1.4.0.orig.tar.gz
 84d2d42adb83f655169092df2fcb15f20e651b9f 2940 
node-resolve_1.4.0-1.debian.tar.xz
 cb7a7335b53e3ec5b4e5beb90827e54034386b59 8184 node-resolve_1.4.0-1_all.deb
 d921a23e59d8d62f869b405075b4a6d388caf497 6695 
node-resolve_1.4.0-1_amd64.buildinfo
Checksums-Sha256:
 06be65c047125a6d354028e7375160325a536d5dbbd194a88ffed2bf072c6f1e 2155 
node-resolve_1.4.0-1.dsc
 9a4ff9d32cceeb666129500bee661f64e838d4864514a61e82d7fa0d8e025ffd 15710 
node-resolve_1.4.0.orig.tar.gz
 e9a3f1a287f4dbcea01264336d99906145aec983cae97c94aac7f1fce776fd5e 2940 
node-resolve_1.4.0-1.debian.tar.xz
 fbae71effc8d5e6c9d74069131d2813c6701267fb8d1da03fbd139008044f3c7 8184 
node-resolve_1.4.0-1_all.deb
 16ba3735c696757f89e633e11ca1f25bb08b5eb35f765399e0f0973f600c9a47 6695 
node-resolve_1.4.0-1_amd64.buildinfo
Files:
 17e2dc4060288ecdded9a798579200dd 2155 web optional node-resolve_1.4.0-1.dsc
 c2dc85e0534567067769dc15aa41f267 15710 web optional 
node-resolve_1.4.0.orig.tar.gz
 24e973201fad95b96063bcaf36414b33 2940 web optional 
node-resolve_1.4.0-1.debian.tar.xz
 792cbe85a655694f04e4d72caf7f4bca 8184 web optional node-resolve_1.4.0-1_all.deb
 177ca271884c30f58b4a59eb6c3b21e3 6695 web optional 
node-resolve_1.4.0-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEYgH7/9u94Hgi6ruWlvysDTh7WEcFAlm+rPRfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYy
MDFGQkZGREJCREUwNzgyMkVBQkI5Njk2RkNBQzBEMzg3QjU4NDcACgkQlvysDTh7
WEcKEQ/+KfwaTebWM0HKa774ABrukRdYayzcEbk72D5gDmditUpEyS2fLsXlcm9x
JoNRWkFufBX0OCIXXhjcZCC1BQ1vSF/Ge0gx4Nh6tl0SzGm89EHDTqg+VU3F5oV2
3thitARvSbtS/KYBkA2YEy+Mx3xC+/u8as6Se1gihnE2STTGg+xxuXXRGemQI06p
kl+mDuqumOWlU8OOxyDxPuLXGPFR0c+WdoeehhbpcpP+BdV9nqiroCjH6GBPvRUt
GmlKbT7IqXrnX56OmcxQ9zkUyJGgMa9wHmy/ZCQapQFEkEYJeH2DTBQVaufay7b7
73uyKjfghCfG6VV+SexwyOn3BdmEf2+MZ2132/lXP0QlMRe4PGnmdw/vmy4MQ2aC
wOEoha6OeX45z27qAs9ziYBEejvlKzWVS9uw+a+EWfYSeaxHjOXgcpqnTdsTVqB9
3qO0JK8C4EUwhdaBBOeRdw9f0j2Ogm5dbMUG2hBj7/Z2VyfNLJNJCy/hcwbgNSJe
SfBBI7tmlCk6fGr3suUyXKBJdh3hICekkTRr5EnzYpyy50ZHEfglBL1bxRdfeRLc
wcbUHOjdMB93FvJ4SPnevbfv21sw3stVwKRdFd1CshJuzOq+Wj/9cxnGKQHjy4xe
H3KoM6LcgUKjHnbzas+0ojqcjnIvtOT/RV17UTVTmx9hQi+SS+0=
=X6oL
-----END PGP SIGNATURE-----

--- End Message ---
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Reply via email to