Your message dated Tue, 19 Sep 2023 17:19:01 +0000
with message-id <e1qienj-00c7ht...@fasolo.debian.org>
and subject line Bug#946300: fixed in horgand 1.14-8
has caused the Debian Bug report #946300,
regarding horgand FTCBFS: broken SSE detection, uses the build architecture 
pkg-config
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
946300: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946300
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: horgand
Version: 1.14-7
Tags: patch upstream
User: debian-cr...@lists.debian.org
Usertags: ftcbfs

horgand fails to cross build from source. For one thing its configure
uses /proc/cpuinfo to determine whether sse is available. This produces
broken results for cross compiling. A better way is asking the compiler
whether it supports -msse. Then it hard codes bare pkg-config. One
should use PKG_CHECK_MODULES instead. The attached patch implements both
and makes horgand cross buildable. Please consider applying it.

Helmut
--- horgand-1.14.orig/configure.in
+++ horgand-1.14/configure.in
@@ -66,16 +66,23 @@
 AC_DEFINE([WEBSITE],["horgand.berlios.de"],[WEBSITE])
 
 
-SSE=$(cat /proc/cpuinfo | grep sse) 
+AC_MSG_CHECKING([for SSE])
+_save_CFLAGS=$CFLAGS
+CFLAGS="$CFLAGS -msse"
+AC_TRY_COMPILE([],[],[
+        AC_MSG_RESULT([yes])
+	SSE=-msse
+],[
+   	AC_MSG_RESULT([no])
+	SSE=
+])
+CFLAGS="$_save_CFLAGS"
 
-if test -z "$SSE"; then 
-SSE=""
-else
-SSE="-msse"
-fi
+PKG_CHECK_MODULES([JACK],[jack])
+PKG_CHECK_MODULES([SNDFILE],[sndfile])
 
-LIBS="`$FLTKCONFIG --ldflags` -lasound `pkg-config --libs jack` `pkg-config --libs sndfile` -lXpm"
-CXXFLAGS="-O3 -fno-rtti -pipe -ffast-math -ffunction-sections -fomit-frame-pointer $SSE -Wall `$FLTKCONFIG --cxxflags` `pkg-config --cflags jack` `pkg-config --cflags sndfile`"
+LIBS="`$FLTKCONFIG --ldflags` -lasound $JACK_LIBS $SNDFILE_LIBS -lXpm"
+CXXFLAGS="-O3 -fno-rtti -pipe -ffast-math -ffunction-sections -fomit-frame-pointer $SSE -Wall `$FLTKCONFIG --cxxflags` $JACK_CFLAGS $SNDFILE_CFLAGS"
 AC_CONFIG_FILES([Makefile src/Makefile data/Makefile man/Makefile])
 AC_OUTPUT
 

--- End Message ---
--- Begin Message ---
Source: horgand
Source-Version: 1.14-8
Done: Bastian Germann <b...@debian.org>

We believe that the bug you reported is fixed in the latest version of
horgand, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 946...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bastian Germann <b...@debian.org> (supplier of updated horgand package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 19 Sep 2023 18:56:13 +0200
Source: horgand
Architecture: source
Version: 1.14-8
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multime...@lists.debian.org>
Changed-By: Bastian Germann <b...@debian.org>
Closes: 946300 974634
Changes:
 horgand (1.14-8) unstable; urgency=medium
 .
   * Team upload
   * Drop kfreebsd annotations
   * Upgrade to fltk1.3 (Closes: #974634)
 .
   [ Ondřej Nový ]
   * d/control: Set Vcs-* to salsa.debian.org
   * d/changelog: Remove trailing whitespaces
   * d/watch: Use https protocol
 .
   [ Felipe Sateler ]
   * Change maintainer address to debian-multime...@lists.debian.org
 .
   [ Olivier Humbert ]
   * Update horgand.desktop (adds FR comment and generic name)
   * Update manpages (adds French manpage)
   * Add French manpage
   * Install an icon used by the desktop file
   * Add an icon to the desktop file (menu item)
   * Update the sources address
   * Update the Homepage address
   * Update control (http -> https)
   * Update copyright (http -> https)
   * Update copyright (add myself)
   * Delete menu (re: CTTE decision, see #741573)
   * Update d/control: fixes 3 typos
 .
   [ Debian Janitor ]
   * Use versioned copyright format URI
   * Update copyright file header to use current field names
     (Name ⇒ Upstream-Name, Maintainer ⇒ Upstream-Contact)
   * Bump debhelper from deprecated 7 to 10
   * Drop unnecessary dependency on dh-autoreconf
   * Fix field name typo in debian/copyright (X-Comment ⇒ Comment)
   * Apply multi-arch hints.
     + horgand-data: Add Multi-Arch: foreign
 .
   [ Helmut Grohne ]
   * Fix FTCBFS (Closes: #946300)
Checksums-Sha1:
 57648f55bdd7dd9a1b36682cb6b3e66dc41d0d08 1961 horgand_1.14-8.dsc
 bd12379d97fbdc12e7c8035f8b822fb446042bfc 6276 horgand_1.14-8.debian.tar.xz
 90298df02387a9072057ae7f15e8e3556ebe6d00 8543 horgand_1.14-8_source.buildinfo
Checksums-Sha256:
 159935da796d300af8d0cbf05a4326f03723047da94b9d6febf9ba37606aa071 1961 
horgand_1.14-8.dsc
 6bdfdd0c05f9ca8a385d371b4b99a8111d04fc1be190324b11bf5d0c7344da49 6276 
horgand_1.14-8.debian.tar.xz
 c9be159b4f88dcd7ea576af3e6fa91278b0a2ba38e9c5596e9d462118d3205a1 8543 
horgand_1.14-8_source.buildinfo
Files:
 0457a8613e41b01eb2a5c11dca5045ac 1961 sound optional horgand_1.14-8.dsc
 d33b67be3f11f45fbf828f024b005e98 6276 sound optional 
horgand_1.14-8.debian.tar.xz
 9c249f9a789185fdb03399f99170cd3e 8543 sound optional 
horgand_1.14-8_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQHEBAEBCgAuFiEEQGIgyLhVKAI3jM5BH1x6i0VWQxQFAmUJ09AQHGJhZ2VAZGVi
aWFuLm9yZwAKCRAfXHqLRVZDFChqDACz/FAwqbYexIYjuBx3PC3Ixp+Q+1vKmpEx
PVGFDN8k3fpkXgoSbzXMcrtgv71OdCiJOcaD9BoaZqdW/6nW+mN9hPTLPmLA4AOr
laxATGUNTktT2GYLEWO5hOm5S8iFr9klgPxIS5zPu8QNPKaep5IcAB994ZshYt2Z
rtNQgpMY92rsFn1Y88hawghtv935fvJ3iIQ84AiZ21c0MqOST2n7vgY/5Bl1jloX
g3KN6HzBPOXEIR/kfGfiKlkzZ5PPFp/WlwmZtS0NSp9a+1k7xPBW6SneDAJ1fno7
/6eB1exPkkEZua3k7d1eQLsf9ZrCj8tZQ0NSjwj4h6A4spZQM04MMsXZ0NePD5Vu
c6GEC0A3T5+Bwkh6Y/7uzKhiggH60AGbHP2p1sVUCi1rz1bNNbAuBdU0wtR6zNzW
d4mlsK15fJMXD0rjpyvvIwDMnPwcxTmjPXkdKPsugC2GI3tV/1xIzG4Bvl6l5w3K
5K6vSq+MSpecTTqBiqn6v38V9jbpaEs=
=fYt9
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Reply via email to