Re: review ghostess

[Jonas Smedegaard]

On Wed, Aug 25, 2010 at 10:29:00PM +0200, rosea grammostola wrote:

As a not very experienced packager, I've added ghostess

http://git.debian.org/git/pkg-multimedia/ghostess.git/

Comments are welcome.

A more useful URL than above is that of the Git browser for the project: http://git.debian.org/?p=pkg-multimedia/ghostess.git

I see that you use CDBS.  Nice! :-D



 1) copy debian/control to debian/control.in
 2) edit debian/control.in replacing cdbs build-dpendency with @cdbs@
 3) invoke the following command to regenerate debian/control:

    DEB_MAINTAINER_MODE=1 fakeroot debian/rules clean

 4) Check what changed in the now auto-updated debian/control
 5) Remove manual entries from debian/control.in now auto-resolved
 6) Repeat steps 3-5 until satisfied
 6) Commit debian/control.in
 7) Commit debian/control (separately!)


I also suggest to enable tracking of copyright/licensing changes:

 1) Include /usr/share/cdbs/1/rules/utils.mk
 2) touch debian/copyright_hints
 3) Invoke the following to generate debian/copyright_newhints:

    DEB_MAINTAINER_MODE=1 debian/rules pre-build

 4) Rename debian/copyright_newhints to debian/copyright_hints
 5) Commit debian/copyright_hints






 1) Include /usr/share/cdbs/1/rules/upstream-tarball.mk



Kind regards,

 - Jonas

--
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

Then I suggest to use auto-resolving of build-dependencies (currently they are not quite optimal): After that, at each build the source is scanned for copyright and licensing hints, and changes compared to the saved hints file trigger a warning (or a failure if DEB_MAINTAINER_MODE=1). I also suggest you enable upstream-tarball handling - i.e. a get-orig-source build target: 2) Add hints to get upstream source (have a look inside the actual upstream-tarball.mk file, or look at e.g. jackd2 for an example)

signature.asc
Description: Digital signature

_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers