-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 salut!
On 2012-03-07 10:54, Loïc Minier wrote: > I've had a look at the changes; thanks for moving to latest packaging thanks for reviewing! > standards (3.0 (quilt), git-bp, pycompat and such) and thanks for > adding the history of uploads by importing the .dsc files. > > I checked your new changes, and most seem good, concerning: > 4fe1e976fd8b49ff2511f7170a13d5ff6de6d2ac > update-rc.d is automagically called by dh_installinit > > IIRC, the byte-compilation was happening by some stanza inserted in > #DEBHELPER# back then, and it was good to restart flumotion after the > byte-compilation had taken place. Otherwise, dh_installinit might > insert the restart snippet before or after byte-compilation, but not > consistenly restart flumotion after byte-compilation. Nowadays, I'm > not sure how to ensure that the daemon is started with the .py files > already byte-compiled. afaics, there is no problem. the original code was something like: <snip> DH_MAGIC call update-rc.d restart the init.d script </snip> this got me lintian _errors_ due to duplicate calls of update-rc.d. close inspection of final postinst script revealed, that DH_MAGIC adds an update-rc.d stanza and starts byte-compilation, so we get: <snip> call update-rc.d do byte-compilation call update-rc.d restart the init.d script </snip> now update-rc.d doesn't restart anything. it only makes sure that the init.d script is called at various runlevels (or however this is called nowadays) therefore, removing the 2nd call to update-rc.d is not harmful, esp. since the code that restarts flumotion after byte-compilation is still there. > The other packaging changes also relate to packaging style, and made > sense in my reading, but I didn't check every single change against the > CDBS documentation or such. if you find the CDBS documentation, please tell me so i can check myself... the only documentation i know of lives in denmark and expressed willingness to "have a look" :-) fgasmdr IOhannes -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk9XSUsACgkQkX2Xpv6ydvRo0wCeMLaeO9J/BvnVH3Yq/1/HOzzA I3wAoJVaCwvnqQf8lLSn/tsNZLlm2tzy =LZRZ -----END PGP SIGNATURE-----
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
