On Sun, Mar 18, 2012 at 5:35 AM, Fabian Greffrath <fab...@greffrath.com> wrote:
>
>> About these latest changes, I removed the build dependency on
>> dh-autoreconf because a) it wasn't necessary, and b) because if we are
>
> It is, because we add
> libdvdcss_la_CFLAGS = -fvisibility=hidden
> in src/Makefile.am
> through debian/patches/symbol-visibility.patch.
>
> Please get this right again. The flag could get added globally to CFLAGS
> in debian/rules, for example.
>
> - Fabian
>
Ok, done.
About your patch, you could do the same for private symbols with a
#define, thus your change doesn't have to be gcc specific. For
example.
#if defined(__GNUC__) && __GNUC__ >= 4
# define LIBDVDCSS_PRIVATE __attribute__((visibility("hidden")))
#else
# define LIBDVDCSS_PRIVATE
#endif
And prepend all private symbols with LIBDVDCSS_PRIVATE.
--
~ Andres
_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
