Hi there. On May 13 2012, Fabian Greffrath wrote: > Am Samstag, den 12.05.2012, 11:29 -0400 schrieb Andres Mejia: > > I just glanced over the changes to this. To be on the safer side, the > > symbols needed by handbrake and provided in audioconvert.c should be > > built from handbrake. This way, any internal changes made to libav for > > audioconvert won't break handbrake. > > IIRC, the only symbol from audioconvert.h that was actually needed was > struct AVAudioConvert, so I declared that myself and was ready with it. > Please compare with my patch from > <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/2012-February/024218.html>:
Sorry for not replying earlier, but I didn't receive these messages of yours (I'm subscribed to the list with an account that I don't check as frequently as my main e-mail). Regarding Fabian's patch, I will steal it and substitute the kludgy solution that I used. Perhaps it would be sane to forward this to the handbrake people? Their code is of very heterogeneous quality: some parts are good, but some are bad. Thanks, -- Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFCAAAA http://rb.doesntexist.org/blog : Projects : https://github.com/rbrito/ DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br _______________________________________________ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers