On 05/19/2014 07:19 PM, Martin Steghöfer wrote: > Just to bring this to your attention once more before moving on to other > places in order to find a reviewer or sponsor. It would be very nice, if > someone could have a look!
here at least a review:
your Vcs: cool that you are using git.
but your workflow seems to be somewhat non-standard (only tracking
debian/ in git). we usually track the entire package in git, which
includes pristine-tarballs from upstream [1].
this eases integration with gbp a lot.
debian/control:
- Vcs-Stanzas:
seem to be missing (most likely because you would like to move the
packaging to a more "debian" repo?)
- Description:
all those acronyms don't mean anything to me; also "support for foo
and bar specifics" sounds weird to me. should that read "supports
formats foo and bar"?
- Depends:
are all those manual dependencies really needed? why can't they be
calculated from by ${shlibs:Depends}
debian/changelog:
usually debian/changelog for an initial upload will only contain a
single line: "* Initial release (Closes: #692968)"
the purpose of this changelog is to report the changes in the packaging
with regard to the last upload. since there is none, you merge all those
changes into "initial packaging".
also, changelog entries should only document versions uploaded to debian.
since 1.3-1 never made it, there is no use documenting it.
debian/rules:
there's some cruft involved here, to include upstream's changelog.
check out dh_installchangelogs.
debian/copyright:
- Source:
the debian/copyright is supposed to not change between upstream-releases
if there are no changes in the copyrights.
this means that you should provide a version-independent link to the
sources, e.g.: http://sourceforge.net/projects/karlyriceditor/files
- License:
according to `licensecheck` all files (with the exception of
./build-*.sh and ./nsis/create_installer.sh which do not have a license
boilerplate) are really GPL-3+
you claim that all files are copyright "2003-2005 James Klicman
<ja...@klicman.org>", of whom i cannot find any references in any file
(but debian/copyright). this may indicate that you did some extra research.
however, all files (excluding those mentioned above) have an explicit
copyright notice "2009-2013 George Yunaev". some have an additional
copyright "2009-2010 Daniel Roggen".
i find it easier to read if all the license-texts are collected at the
end of debian/copyright.
something like
<snip>
Files: *
Copyright: 2000-2001, John Doe
License: foo
Files: debian/*
Copyright: 2042, Mimi Minus
License: foo
License: foo
this is a foo license...
</snip>
finally:
the package FTBFS in a pristine sid environment (using
pbuilder/git-buildpackage).
most likely the package is needs some work for libav10.
<snip>
ffmpegvideodecoder.cpp: In member function 'bool
FFMpegVideoDecoder::openFile(const QString&, unsigned int)':
ffmpegvideodecoder.cpp:116:57: error: 'AVStream' has no member named
'r_frame_rate'
d->m_fps_den = d->pFormatCtx->streams[d->videoStream]->r_frame_rate.den;
^
ffmpegvideodecoder.cpp:117:57: error: 'AVStream' has no member named
'r_frame_rate'
d->m_fps_num = d->pFormatCtx->streams[d->videoStream]->r_frame_rate.num;
^
ffmpegvideodecoder.cpp:142:14: warning: 'AVFrame* avcodec_alloc_frame()'
is deprecated (declared at /usr/include/libavcodec/avcodec.h:3114)
[-Wdeprecated-declarations]
d->pFrame = avcodec_alloc_frame();
[...] ^
Makefile:709: recipe for target 'ffmpegvideodecoder.o' failed
make[2]: *** [ffmpegvideodecoder.o] Error 1
make[2]: Leaving directory '/tmp/buildd/karlyriceditor-1.11/src'
Makefile:117: recipe for target 'sub-src-check' failed
make[1]: *** [sub-src-check] Error 2
make[1]: Leaving directory '/tmp/buildd/karlyriceditor-1.11'
dh_auto_test: make -j1 check returned exit code 2
debian/rules:22: recipe for target 'build' failed
make: *** [build] Error 2
</snip>
fmgadsr
IOhannes
[1] https://wiki.debian.org/DebianMultimedia/DevelopPackaging
signature.asc
Description: OpenPGP digital signature
_______________________________________________ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
