On Thu, Feb 19, 2015 at 6:20 AM, Tino Mettler <tino.mett...@alcnetworx.de> wrote: > On Wed, 2015-02-18 at 22:46 +0100, "IOhannes m zmölnig (Debian/GNU)" > wrote: > >> me too (and I am personally interested in ptp packages). >> however, i would welcome it if the package would be team-maintained >> under the pkg-multimedia umbrella. > > Hi, > > thanks for the offer. > >> >> anyhow, i'm currently doing a quick review of the package. >> some notes: >> >> - i very much prefer to build the package using git(-buildpackage) to >> just buliding packages from mentors.d.n, as this is my proven toolchain >> to build in a chroot environment. >> i am not a gitpkg user though, so i need some help, which you already >> provide in the debian/README.source (thanks for that!). >> unfortunately the information therein is not sufficient (and the >> pristine-tar line mentioning "syncevolution" is rather suspicious). >> i cloned http://tikei.de/git/linuxptp-debian.git and setup the >> quilt-patches hook; but running `gitpkg master` gives me the following >> error: >> >> ~~~ >> $ gitpkg master >> git archive exporting master >> preparing ../deb-packages/linuxptp/linuxptp-1.5 >> dpkg-source -b linuxptp-1.5 >> dpkg-source: info: using source format `3.0 (quilt)' >> dpkg-source: info: building linuxptp using existing >> ./linuxptp_1.5.orig.tar.gz >> patching file makefile >> Reversed (or previously applied) patch detected! Skipping patch. >> 1 out of 1 hunk ignored >> dpkg-source: info: the patch has fuzz which is not allowed, or is malformed >> dpkg-source: info: if patch >> '0001-Adjust-installation-directory-for-Debian.patch' is correctly >> applied by quilt, use 'quilt refresh' to update it >> dpkg-source: error: LC_ALL=C patch -t -F 0 -N -p1 -u -V never -g0 -E -b >> -B .pc/0001-Adjust-installation-directory-for-Debian.patch/ >> --reject-file=- < >> linuxptp-1.5.orig.zcTD_d/debian/patches/0001-Adjust-installation-directory-for-Debian.patch >> gave error exit status 1 > > There is a git config command missing in the instructions, sorry for > this: > > $ git config gitpkg.pre-export-hook > /usr/share/gitpkg/hooks/pristine-tar-pre-export-hook > > I'll add this to README.source.
FWIW, I also prefer git-buildpackage. Whenever I've seen gitpkg it is too complex to use, as it requires configuration by the user. On the other hand, git-buildpackage is as simple as: gbp clone/pull ; gbp buildpackage. We have agreed in the team to use git-buildpackage when possible[1] to standarize on a single tool. I hope you reconsider using gbp instead. [1] https://wiki.debian.org/DebianMultimedia/DevelopPackaging -- Saludos, Felipe Sateler _______________________________________________ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers