execstack -c /usr/lib/x86_64-linux-gnu/libwavpack.so.1.1.6

The executable stack flag can be cleared with the above command.  After that 
mplayer works on a SE Linux system in enforcing mode.  It could be that there 
is some code path in this shared object that isn't called by mplayer that 
requires an executable stack, but it seems unlikely.

.section .note.GNU-stack,"",@progbits

I built that package with the above line added at the start of each assembler 
file to instruct the linker that the assembly code didn't require an 
executable stack (I've attached a patch).

With that patch the library works as desired in enforcing mode.

The problem is that the assembler/linker considers that all assembly code 
needs an executable stack by default when really hardly code needs it, 
especially on AMD64.

-- 
My Main Blog         http://etbe.coker.com.au/
My Documents Blog    http://doc.coker.com.au/
--- wavpack-4.75.0.orig/src/pack_x64.s
+++ wavpack-4.75.0/src/pack_x64.s
@@ -6,6 +6,7 @@
 ##      Distributed under the BSD Software License (see license.txt)      ##
 ############################################################################
 
+.section .note.GNU-stack,"",@progbits
         .intel_syntax noprefix
         .text
 
--- wavpack-4.75.0.orig/src/pack_x86.s
+++ wavpack-4.75.0/src/pack_x86.s
@@ -5,6 +5,7 @@
 ##                          All Rights Reserved.                          ##
 ##      Distributed under the BSD Software License (see license.txt)      ##
 ############################################################################
+.section .note.GNU-stack,"",@progbits
 
         .intel_syntax noprefix
         .text
--- wavpack-4.75.0.orig/src/unpack_armv7.s
+++ wavpack-4.75.0/src/unpack_armv7.s
@@ -5,6 +5,7 @@
 //                          All Rights Reserved.                          //
 //      Distributed under the BSD Software License (see license.txt)      //
 ////////////////////////////////////////////////////////////////////////////
+.section .note.GNU-stack,"",@progbits
 
         .text
         .align
--- wavpack-4.75.0.orig/src/unpack_x64.s
+++ wavpack-4.75.0/src/unpack_x64.s
@@ -5,6 +5,7 @@
 ##                          All Rights Reserved.                          ##
 ##      Distributed under the BSD Software License (see license.txt)      ##
 ############################################################################
+.section .note.GNU-stack,"",@progbits
 
         .intel_syntax noprefix
         .text
--- wavpack-4.75.0.orig/src/unpack_x86.s
+++ wavpack-4.75.0/src/unpack_x86.s
@@ -5,6 +5,7 @@
 ##                          All Rights Reserved.                          ##
 ##      Distributed under the BSD Software License (see license.txt)      ##
 ############################################################################
+.section .note.GNU-stack,"",@progbits
 
         .intel_syntax noprefix
         .text
_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Reply via email to