Your message dated Mon, 03 Jan 2022 11:49:22 +0000 with message-id <[email protected]> and subject line Bug#743279: fixed in pngtools 0.5~git20211218.2f4c05c-1 has caused the Debian Bug report #743279, regarding pnginfo returns random numbers as return code. to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 743279: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=743279 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package:pngtools Version:0.4-1 Hello, pnginfo returns random numbers as return code. No chance to tell wether it failed or succeeded. Only a few lines need to be changed. Markusdiff -Nbur pngtools-0.4.orig/debian/changelog pngtools-0.4/debian/changelog --- pngtools-0.4.orig/debian/changelog 2014-04-01 11:44:19.000000000 +0200 +++ pngtools-0.4/debian/changelog 2014-04-01 11:29:10.928408006 +0200 @@ -1,3 +1,10 @@ +pngtools (0.4-1.1) UNRELEASED; urgency=low + + * Non-maintainer upload. + * Make pnginfo return a code for error or success. + + -- Markus <markus@deb-71-build-64> Tue, 01 Apr 2014 11:27:46 +0200 + pngtools (0.4-1) unstable; urgency=low * New upstream release; diff -Nbur pngtools-0.4.orig/debian/pnginfo.1 pngtools-0.4/debian/pnginfo.1 --- pngtools-0.4.orig/debian/pnginfo.1 2014-04-01 11:44:19.000000000 +0200 +++ pngtools-0.4/debian/pnginfo.1 2014-04-01 11:36:53.416408061 +0200 @@ -11,7 +11,8 @@ .PP The format for the output bitmaps is hexadecimal, with each pixel presented as a triple \-\- for instance [red green blue]. This means that paletted images et cetera will have their bitmaps expanded before display. .SH RETURNS -Nothing. + 0 success + 1 error .SH EXAMPLE pnginfo \-t toucan.png basn3p02.png basn6a16.png toucan.png... diff -Nbur pngtools-0.4.orig/pnginfo.c pngtools-0.4/pnginfo.c --- pngtools-0.4.orig/pnginfo.c 2008-11-27 00:14:17.000000000 +0100 +++ pngtools-0.4/pnginfo.c 2014-04-01 11:29:45.808407925 +0200 @@ -18,7 +18,9 @@ The format for the output bitmaps is hexadecimal, with each pixel presented as a triple -- for instance [red green blue]. This means that paletted images et cetera will have their bitmaps expanded before display. DESCRIPTION END -RETURNS Nothing +RETURNS + 0 success + 1 error EXAMPLE START %bash: pnginfo -t toucan.png basn3p02.png basn6a16.png @@ -127,6 +129,8 @@ // For each filename that we have: for (; i < argc; i++) pnginfo_displayfile (argv[i], extractBitmap, displayBitmap, tiffnames); + + return 0; } void @@ -153,11 +157,7 @@ // Check that it really is a PNG file fread (sig, 1, 8, image); if (!png_check_sig (sig, 8)) - { - printf (" This file is not a valid PNG file\n"); - fclose (image); - return; - } + pnginfo_error ("This file is not a valid PNG file."); // Start decompressing if ((png = png_create_read_struct (PNG_LIBPNG_VER_STRING, NULL, @@ -451,7 +451,7 @@ pnginfo_error (char *message) { fprintf (stderr, "%s\n", message); - exit (42); + exit (1); } // Allocate some memory
--- End Message ---
--- Begin Message ---Source: pngtools Source-Version: 0.5~git20211218.2f4c05c-1 Done: Mathieu Malaterre <[email protected]> We believe that the bug you reported is fixed in the latest version of pngtools, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Mathieu Malaterre <[email protected]> (supplier of updated pngtools package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Mon, 03 Jan 2022 12:31:24 +0100 Source: pngtools Architecture: source Version: 0.5~git20211218.2f4c05c-1 Distribution: unstable Urgency: medium Maintainer: Debian PhotoTools Maintainers <[email protected]> Changed-By: Mathieu Malaterre <[email protected]> Closes: 544489 668436 743279 Changes: pngtools (0.5~git20211218.2f4c05c-1) unstable; urgency=medium . * d/control: Update to new Vcs URLs * d/rules: Make sure to compile without error * New upstream version 0.5~git20211218.2f4c05c * d/patches: Import pull requests from upstream repo. Closes: #544489, #668436, #743279 * d/rules: Properly generate man page from upstream SGML Checksums-Sha1: 5704ecba6d6079daddb4077f0f1e04ad16582812 2130 pngtools_0.5~git20211218.2f4c05c-1.dsc cf53b70d979ad6d58b44e10df3bc15b1ead8dfd5 633448 pngtools_0.5~git20211218.2f4c05c.orig.tar.xz d86e3a7c5ec50ce15d45be9eb29e42a14170df85 7220 pngtools_0.5~git20211218.2f4c05c-1.debian.tar.xz c4976df959fc1d0133d35e4ff066fbcf86763975 9292 pngtools_0.5~git20211218.2f4c05c-1_source.buildinfo Checksums-Sha256: 471543c3fe1d76ddbbbf898d021fcb2e02d9f50201b1f4b85d9eeffa233f20a5 2130 pngtools_0.5~git20211218.2f4c05c-1.dsc aa311a7ca5154c22138da8cb8316e8c2aff3e75f244151e4e8926f99746fe59b 633448 pngtools_0.5~git20211218.2f4c05c.orig.tar.xz d02b4db6b2a8277ffeefad38f557a9913cbabcbb875f4ef460c2b8ba24fa6772 7220 pngtools_0.5~git20211218.2f4c05c-1.debian.tar.xz 216cf4dc908699745f5eecfa3b0eeaf2f0c43191c02cd3ab5b2ff7aba7ea4769 9292 pngtools_0.5~git20211218.2f4c05c-1_source.buildinfo Files: ef3fbb914d2eaf1408485ac036566416 2130 graphics optional pngtools_0.5~git20211218.2f4c05c-1.dsc 47296ae736bd9dceca529d60c65da051 633448 graphics optional pngtools_0.5~git20211218.2f4c05c.orig.tar.xz acb383e8b48a28a7911d7d7405756ee7 7220 graphics optional pngtools_0.5~git20211218.2f4c05c-1.debian.tar.xz 0f7d6ad1ffcd1b26193f47646519c90d 9292 graphics optional pngtools_0.5~git20211218.2f4c05c-1_source.buildinfo -----BEGIN PGP SIGNATURE----- iQJFBAEBCgAvFiEEaTNn/67NjqrNHwY7AXHhgorgk0UFAmHS3xARHG1hbGF0QGRl Ymlhbi5vcmcACgkQAXHhgorgk0V0qhAAiGECG+8TndBHu6tppir0ulkHJt4hUsMd nFvm4fNHRVhrCYbCwOfc9r4Gaj0+8sXOqRw5rs//qobVsX5nVqowEgRurre0CIru xjFAwWlz4M48MFJalki48NS/eg+V1rQHhWy+oahMXHYkn8ljl7asMpMrhUCofrSn uPV2LQPIXhIwIhsWlvEIwLSqRsEOuPl+naN5ZSTdxeMOK/eojLW/7F11Ck0zDoI8 /rsBMnqf07nPOkmXycoDgJZRh8GB5TUrSprTW4MEbXgpXHQT+8Vot0VQcTgQ+2Wa OaqPd19wYww6YwG0wTwiZlwONxLJbIv65xi/6kdzzVaD9/k7ZVKLYgozZ1Dkl3sF 7y/KdmDT4slbTRSLzZqHzdXlcMdXdwNxWnuY2TZMAC4Izc6rJXozBQpRVmgN4jLu NEZn4KHUh8Zd53l1bGOHmRuPJFef31xPKVfNBVBdOo6KXXhHQPVNgL6rtSxnF+/t KnyTykNa0fFU57PJMs7k+P1N7V898lNxOX8l9Jbr5jIrkQd5GAA5XmuMOjgS7Udj z4TPGM8mWh79NJP/zVDQXVALWeAhUlRqQIoEc19uL0y2UrzmPGtGmo/bRQrN6hJC wbRGUO+dnnW6HWeaxckXl+KvnMaX1y77pOYQjAh8J2XEecXWT5DQYo2jBd3QXGpA 9O0P1jI1B1o= =bLAQ -----END PGP SIGNATURE-----
--- End Message ---
-- Pkg-phototools-devel mailing list [email protected] https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-phototools-devel
